-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
seccomp: Add support for SCMP_ACT_KILL_PROCESS #1044
Conversation
Signed-off-by: Paulo Gomes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM Just to be clear, this was part of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, too
LGTM. @caniszczyk Looks like I'm not set up for PullApprove? |
OCI spec added SCMP_ACT_KILL_THREAD and SCMP_ACT_KILL_PROCESS almost two years ago ([1], [2]), but runc support was half-finished [3]. Add these actions, and modify the test case to check them. In addition, "runc features" now lists the new actions. [1] opencontainers/runtime-spec#1044 [2] opencontainers/runtime-spec#1064 [3] https://github.com/opencontainers/runc/pulls/3204 Fixes: 4a4d4f1 Signed-off-by: Kir Kolyshkin <[email protected]>
OCI spec added SCMP_ACT_KILL_THREAD and SCMP_ACT_KILL_PROCESS almost two years ago ([1], [2]), but runc support was half-finished [3]. Add these actions, and modify the test case to check them. In addition, "runc features" now lists the new actions. [1] opencontainers/runtime-spec#1044 [2] opencontainers/runtime-spec#1064 [3] https://github.com/opencontainers/runc/pulls/3204 Fixes: 4a4d4f1 Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit e74fdeb)
OCI spec added SCMP_ACT_KILL_THREAD and SCMP_ACT_KILL_PROCESS almost two years ago ([1], [2]), but runc support was half-finished [3]. Add these actions, and modify the test case to check them. In addition, "runc features" now lists the new actions. [1] opencontainers/runtime-spec#1044 [2] opencontainers/runtime-spec#1064 [3] https://github.com/opencontainers/runc/pulls/3204 Fixes: 4a4d4f1 Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit e74fdeb) (cherry picked from commit 68427f3) Signed-off-by: Kir Kolyshkin <[email protected]>
OCI spec added SCMP_ACT_KILL_THREAD and SCMP_ACT_KILL_PROCESS almost two years ago ([1], [2]), but runc support was half-finished [3]. Add these actions, and modify the test case to check them. In addition, "runc features" now lists the new actions. [1] opencontainers/runtime-spec#1044 [2] opencontainers/runtime-spec#1064 [3] https://github.com/opencontainers/runc/pulls/3204 Fixes: 4a4d4f1 Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit e74fdeb) (cherry picked from commit 68427f3) Signed-off-by: Kir Kolyshkin <[email protected]>
OCI spec added SCMP_ACT_KILL_THREAD and SCMP_ACT_KILL_PROCESS almost two years ago ([1], [2]), but runc support was half-finished [3]. Add these actions, and modify the test case to check them. In addition, "runc features" now lists the new actions. [1] opencontainers/runtime-spec#1044 [2] opencontainers/runtime-spec#1064 [3] https://github.com/opencontainers/runc/pulls/3204 Fixes: 3b90240 Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit e74fdeb) (cherry picked from commit 68427f3) Signed-off-by: Kir Kolyshkin <[email protected]>
OCI spec added SCMP_ACT_KILL_THREAD and SCMP_ACT_KILL_PROCESS almost two years ago ([1], [2]), but runc support was half-finished [3]. Add these actions, and modify the test case to check them. In addition, "runc features" now lists the new actions. [1] opencontainers/runtime-spec#1044 [2] opencontainers/runtime-spec#1064 [3] https://github.com/opencontainers/runc/pulls/3204 Fixes: 84e6025 Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit e74fdeb) (cherry picked from commit 8604590d59ca5c6e3608244e49d888e0e92c7585) Signed-off-by: Kir Kolyshkin <[email protected]>
Adds support for SCMP_ACT_KILL_PROCESS, which allows users to kill the entire process when a syscall blocked by seccomp is called.
Signed-off-by: Paulo Gomes [email protected]