Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ociVersion of Configuration Schema Example to support ambient capability #1009

Merged

Conversation

KentaTada
Copy link
Contributor

Correct ociVersion is not specified in Configuration Schema Example.
ociVersion 0.5.0-dev does not support Linux ambient capability.

Signed-off-by: Kenta Tada [email protected]

@KentaTada
Copy link
Contributor Author

Could someone review this commit? cc @titanous @vbatts @crosbymichael @cyphar @alban

@crosbymichael
Copy link
Member

crosbymichael commented May 16, 2019

LGTM

Approved with PullApprove

@crosbymichael
Copy link
Member

There is still something up with your DCO, It does not like your signoff for some reason ;)

@KentaTada
Copy link
Contributor Author

I don't know why my pullapprove was failed. Can some maintainers please teach me how to resolve it if you know?

@vbatts
Copy link
Member

vbatts commented May 20, 2019

LGTM

Approved with PullApprove

@KentaTada
Copy link
Contributor Author

@crosbymichael @vbatts Thank you for your review. Please let me know if there is anything I can do. I’ll be waiting for merge or comments.

@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit 8ffda14 into opencontainers:master Jun 4, 2019
@vbatts vbatts mentioned this pull request Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants