Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] try Go 1.24 #4598

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[DNM] try Go 1.24 #4598

wants to merge 1 commit into from

Conversation

kolyshkin
Copy link
Contributor

Currently at -rc.2.

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin
Copy link
Contributor Author

Nice, we have a problem with exec.

@akhilerm
Copy link
Contributor

Nice, we have a problem with exec.

Curious how you found there was an issue with exec, all the github actions job logs says that it has been cancelled.

@kolyshkin
Copy link
Contributor Author

Curious how you found there was an issue with exec, all the github actions job logs says that it has been cancelled.

Sure.

It has been cancelled because of timeout. The timeout is happening because one of the bats tests hangs. The output from the test shows the last successful test, if you take a look at a log from a successful run you'll see the next test is runc exec --cap. When I tried the same test locally, and then I saw that in fact every test case which involves exec and has stdin is hanging in the same way.

@kolyshkin
Copy link
Contributor Author

  1. I suspect this is a kernel bug, reported it here: https://lore.kernel.org/linux-fsdevel/[email protected]/T/#u.
  2. I have also reported this issue to Golang: io: Copy to a pipe prevents process exit (Go 1.24rc2 on Linux regression) golang/go#71375

@kolyshkin
Copy link
Contributor Author

Opened #4602 to track this for runc.

@thaJeztah
Copy link
Member

Interesting; great digging! Seems like moby may be missing a test-case for this, or at least I recall my test-PR with go 1.24rc1 completed succesfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants