Drop Go 1.13 support, require go 1.15+ #3100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
previously approved these changes
Jul 20, 2021
|
@thaJeztah PTAL |
thaJeztah
previously approved these changes
Jul 20, 2021
Yes (definitely not to backport to 1.0.x). |
This reverts commit 1a659bc, essentially reinstating commit d0cbef5. Signed-off-by: Kir Kolyshkin <[email protected]>
This reverts commit 45f49e8. Signed-off-by: Kir Kolyshkin <[email protected]>
This mostly reverts commit e2dd922, and bumps the min Go version to 1.15. Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
This simplifies the code as no explicit cleanup is required. Signed-off-by: Kir Kolyshkin <[email protected]>
This simplifies the code as no explicit cleanup is required. Signed-off-by: Kir Kolyshkin <[email protected]>
1. Use t.TempDir instead of ioutil.TempDir. This means no need for an explicit cleanup, which removes some code, including newTestBundle and newTestRoot. 2. Move newRootfs invocation down to newTemplateConfig, removing a need for explicit rootfs creation. Also, remove rootfs from tParam as it is no longer needed (there was a since test case in which two containers shared the same rootfs, but it does not look like it's required for the test). Signed-off-by: Kir Kolyshkin <[email protected]>
Replace ioutil.TempDir (mostly) with t.TempDir, which require no explicit cleanup. While at it, fix incorrect usage of os.ModePerm in libcontainer/intelrdt test. This is supposed to be a mask, not mode bits. Signed-off-by: Kir Kolyshkin <[email protected]>
|
Rebased on top of current master. Can we please merge it? I have another PR which touches the same code. |
AkihiroSuda
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker/Moby v20.10.8 will bump up Go requirement from 1.13 to 1.16: moby/moby#42643
So we can safely drop support for Go 1.13.
Also, Go 1.14 is no longer supported, so let's settle on Go 1.15+
(which allows to use t.Cleanup and t.TempDir, shaving off some test code).
Go release notes:
Fixes: #3098