ci: add go1.17 #3021
Merged
ci: add go1.17 #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
force-pushed
the
go-1.17beta1
branch
2 times, most recently
from
68005a2 to
1020824
Compare
kolyshkin
force-pushed
the
go-1.17beta1
branch
3 times, most recently
from
02ad38d to
194b806
Compare
|
CI failure is unrelated (#3050) |
|
Rebased. |
|
Updated to 1.17-rc1 |
|
Removed go 1.15 |
kolyshkin
force-pushed
the
go-1.17beta1
branch
2 times, most recently
from
8b42a04 to
7a0053c
Compare
kolyshkin
force-pushed
the
go-1.17beta1
branch
2 times, most recently
from
af5fae9 to
6db56cf
Compare
|
We have 1.17 GA now https://golang.org/dl/ |
AkihiroSuda
added
the
backport/1.0-todo
kolyshkin
force-pushed
the
go-1.17beta1
branch
from
6db56cf to
daef138
Compare
|
Updated to GA; rebased; no longer a draft. |
AkihiroSuda
reviewed
Aug 16, 2021
| @@ -17,7 +17,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| go-version: [1.15.x, 1.16.x] | |||
| go-version: [1.15.x, 1.16.x, 1.17.x] | |||
There was a problem hiding this comment.
Dockerfile needs to be update
Line 1 in 55e93b8
There was a problem hiding this comment.
Can we drop support for Go 1.15?
There was a problem hiding this comment.
Dockerfile needs to be update
done
Can we drop support for Go 1.15?
I'd say let's have it for some time as it just became unsupported a day ago.
This is also a separate issue; I'd like to add 1.17 now and drop 1.15 later and separately.
Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
go-1.17beta1
branch
from
daef138 to
a587180
Compare
AkihiroSuda
approved these changes
Aug 18, 2021
mrunalp
approved these changes
Aug 18, 2021
Closed
kolyshkin
added
backport/1.0-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping this as draft until go1.17 is released. Will rebase periodically to test master with go 1.17.
1.0 backport: #3299