Fixing some lint issues #2631
Merged
Fixing some lint issues #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knabben
force-pushed
the
fix-some-lints
branch
from
adaf37e to
2d6bffe
Compare
AkihiroSuda
reviewed
Oct 3, 2020
libcontainer/cgroups/utils.go
Outdated
| @@ -269,7 +269,6 @@ func RemovePaths(paths map[string]string) (err error) { | |||
| } | |||
| } | |||
| if len(paths) == 0 { | |||
| paths = make(map[string]string) | |||
knabben
force-pushed
the
fix-some-lints
branch
from
2d6bffe to
23e0f80
Compare
kolyshkin
reviewed
Oct 5, 2020
contrib/cmd/recvtty/recvtty.go
Outdated
Comment on lines
108
to
109
| err = console.ClearONLCR(c.Fd()) | ||
| if err != nil { |
There was a problem hiding this comment.
Suggested change
| err = console.ClearONLCR(c.Fd()) | |
| if err != nil { | |
| if err := console.ClearONLCR(c.Fd()); if err != nil { |
There was a problem hiding this comment.
Suggestion applied in the squashed commit.
knabben
force-pushed
the
fix-some-lints
branch
from
23e0f80 to
7343c52
Compare
kolyshkin
reviewed
Oct 6, 2020
notify_socket.go
Outdated
| client.Write([]byte(newPid + "\n")) | ||
| _, err := client.Write([]byte(newPid + "\n")) | ||
| if err != nil { | ||
| return nil |
There was a problem hiding this comment.
Did you mean
Suggested change
| return nil | |
| return err |
?
knabben
force-pushed
the
fix-some-lints
branch
2 times, most recently
from
4c78fbf to
8abbcfe
Compare
|
@kolyshkin @AkihiroSuda PTAL |
kolyshkin
reviewed
Oct 6, 2020
libcontainer/intelrdt/intelrdt.go
Outdated
| @@ -294,8 +294,11 @@ func getIntelRdtRoot() (string, error) { | |||
| } | |||
|
|
|||
| func isIntelRdtMounted() bool { | |||
| _, err := getIntelRdtRoot() | |||
| return err == nil | |||
| if _, err := getIntelRdtRoot(); err != nil { | |||
There was a problem hiding this comment.
This hunk looks weird. This was just fixed in commit e8eb800 and it seems you're reverting the change by mistake.
Signed-off-by: Amim Knabben <[email protected]>
knabben
force-pushed
the
fix-some-lints
branch
from
8abbcfe to
978fa6e
Compare
kolyshkin
approved these changes
Oct 6, 2020
|
@AkihiroSuda @mrunalp PTAL |
mrunalp
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some issues from #2627
contrib/cmd/recvtty/recvtty.go:108:20: Error return value of
console.ClearONLCRis not checked (errcheck)libcontainer/cgroups/systemd/common.go:377:3: S1023: redundant
returnstatement (gosimple)libcontainer/configs/validate/validator.go:231:5: S1002: should omit comparison to bool constant, can be simplified to
!symLink(gosimple)libcontainer/container_linux.go:1531:2: S1006: should use for {} instead of for true {} (gosimple)
libcontainer/integration/checkpoint_test.go:238:2: SA4006: this value of
processis never used (staticcheck)libcontainer/integration/checkpoint_test.go:258:12: S1030: should use stdout.String() instead of string(stdout.Bytes()) (gosimple)
libcontainer/integration/exec_test.go:282:11: S1030: should use stdout.String() instead of string(stdout.Bytes()) (gosimple)
libcontainer/integration/exec_test.go:285:12: S1030: should use stdout2.String() instead of string(stdout2.Bytes()) (gosimple)
libcontainer/integration/exec_test.go:328:15: S1030: should use stdout.String() instead of string(stdout.Bytes()) (gosimple)
libcontainer/integration/exec_test.go:1504:21: S1030: should use stdout2.String() instead of string(stdout2.Bytes())
(gosimple)
libcontainer/nsenter/nsenter_test.go:229:2: S1023: redundant
returnstatement (gosimple)libcontainer/seccomp/config.go:65:29: S1002: should omit comparison to bool constant, can be simplified to
ok(gosimple)libcontainer/seccomp/config.go:73:28: S1002: should omit comparison to bool constant, can be simplified to
ok(gosimple)libcontainer/user/user_test.go:466:3: S1032: should use sort.Ints(...) instead of sort.Sort(sort.IntSlice(...)) (gosimple)
libcontainer/user/user_test.go:502:3: S1032: should use sort.Ints(...) instead of sort.Sort(sort.IntSlice(...)) (gosimple)
notify_socket.go:165:16: Error return value of
client.Writeis not checked (errcheck)