cgroup2: exec: join the cgroup of the init process on EBUSY #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
force-pushed
the
exec-join-init-cgroup
branch
4 times, most recently
from
e93631c to
dc133ec
Compare
AkihiroSuda
force-pushed
the
exec-join-init-cgroup
branch
2 times, most recently
from
4ece281 to
9643a87
Compare
|
@kolyshkin @cyphar @giuseppe PTAL |
giuseppe
reviewed
May 21, 2020
| // On cgroup v2 + nesting + domain controllers, EnterPid may fail with EBUSY. | ||
| // https://github.com/opencontainers/runc/issues/2356#issuecomment-621277643 | ||
| // Try to join the cgroup of InitProcessPid. | ||
| if cgroups.IsCgroup2UnifiedMode() { |
There was a problem hiding this comment.
should it not be done only with err == EBUSY?
There was a problem hiding this comment.
I guess it is worth trying to join pid1 even on other errors
|
@kolyshkin @mrunalp PTAL |
mrunalp
reviewed
May 27, 2020
mrunalp
reviewed
May 27, 2020
|
Added one comment about removing the warning otherwise looks ready to merge. Thanks! |
AkihiroSuda
force-pushed
the
exec-join-init-cgroup
branch
from
9643a87 to
5099176
Compare
|
updated |
|
Thanks, will tag once tests pass again. |
|
LGTM |
|
@kolyshkin @cyphar ptal |
kolyshkin
reviewed
May 29, 2020
AkihiroSuda
force-pushed
the
exec-join-init-cgroup
branch
from
5099176 to
b502a4b
Compare
kolyshkin
reviewed
May 30, 2020
kolyshkin
previously approved these changes
May 30, 2020
Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
exec-join-init-cgroup
branch
from
b502a4b to
c91fe9a
Compare
|
fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2356.
Contains #2418Note: this behavior is different from crun v0.13.
crun joins "crun-exec` group rather than the init group: containers/crun@af1080b
The next version of crun will switch to the init cgroup: containers/crun#365