Update console dependency to fix runc exec on BE #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug in the console package for big-endian architectures. When creating a new pty the returned path to the new pty slave was wrong for the second und all subsequent ptys. In runc the exec subcommand failed with an runtime error such as `container_linux.go:265: starting container process caused "open /dev/pts/4294967296: no such file or directory"`. The number is shifted by 32. Signed-off-by: Peter Morjan <[email protected]>
|
LGTM |
1 similar comment
|
LGTM |
Closed
3 tasks
This was referenced Feb 28, 2018
alicefr
pushed a commit
to alicefr/agent
that referenced
this pull request
Nov 14, 2018
This PR fixes the issue kata-containers#410 The console package in vendor contains a big endian bug. The issue has already been solved in runc. See PRs: - opencontainers/runc#1727 - containerd/console#20 The console version has been updated from commit 84eeaae905 to commit 2748ece166. The console package has been add in the Gopkg.toml because the console package is not directly used in the code and the dep command doesn't automatically update the console package. Signed-off-by: Alice Frosi <[email protected]>
alicefr
pushed a commit
to alicefr/agent
that referenced
this pull request
Nov 14, 2018
This PR fixes the issue kata-containers#410 The console package in vendor contains a big endian bug. The issue has already been solved in runc. See PRs: - opencontainers/runc#1727 - containerd/console#20 The console version has been updated from commit 84eeaae905 to commit 2748ece166. The console package has been add in the Gopkg.toml because the console package is not directly used in the code and the dep command doesn't automatically update the console package. Signed-off-by: Alice Frosi <[email protected]>
alicefr
pushed a commit
to alicefr/agent
that referenced
this pull request
Nov 14, 2018
This PR fixes the issue kata-containers#410 The console package in vendor contains a big endian bug. The issue has already been solved in runc. See PRs: - opencontainers/runc#1727 - containerd/console#20 The console version has been updated from commit 84eeaae905 to commit 2748ece166 (commit that fixed the big-endian issue) The console package has been added in the Gopkg.toml because the console package is not directly used in the code and the dep command doesn't automatically update the console package. Signed-off-by: Alice Frosi <[email protected]>
alicefr
pushed a commit
to alicefr/agent
that referenced
this pull request
Nov 15, 2018
The console package in vendor contains a big endian bug. The issue has already been solved in runc. See PRs: - opencontainers/runc#1727 - containerd/console#20 The console version has been updated from commit 84eeaae905 to commit 2748ece166 (commit that fixed the big-endian issue) The console package has been added in the Gopkg.toml because the console package is not directly used in the code and the dep command doesn't automatically update the console package. Signed-off-by: Alice Frosi <[email protected]>
alicefr
pushed a commit
to alicefr/agent
that referenced
this pull request
Nov 15, 2018
Fixes: kata-containers#410 The console package in vendor contains a big endian bug. The issue has already been solved in runc. See PRs: - opencontainers/runc#1727 - containerd/console#20 The console version has been updated from commit 84eeaae905 to commit 2748ece166 (commit that fixed the big-endian issue) The console package has been added in the Gopkg.toml because the console package is not directly used in the code and the dep command doesn't automatically update the console package. Signed-off-by: Alice Frosi <[email protected]>
alicefr
pushed a commit
to alicefr/agent
that referenced
this pull request
Nov 15, 2018
Fixes: kata-containers#410 The console package in vendor contains a big endian bug. The issue has already been solved in runc. See PRs: - opencontainers/runc#1727 - containerd/console#20 The console version has been updated from commit 84eeaae905 to commit 2748ece166 (commit that fixed the big-endian issue) The console package has been added in the Gopkg.toml because the console package is not directly used in the code and the dep command doesn't automatically update the console package. Signed-off-by: Alice Frosi <[email protected]>
alicefr
pushed a commit
to alicefr/agent
that referenced
this pull request
Nov 15, 2018
Fixes: kata-containers#410 The console package in vendor contains a big endian bug. The issue has already been solved in runc. See PRs: - opencontainers/runc#1727 - containerd/console#20 The console version has been updated from commit 84eeaae905 to commit 2748ece166 (commit that fixed the big-endian issue) The console package has been added in the Gopkg.toml because the console package is not directly used in the code and the dep command doesn't automatically update the console package. Signed-off-by: Alice Frosi <[email protected]>
jshachm
pushed a commit
to jshachm/agent
that referenced
this pull request
Nov 22, 2018
Fixes: kata-containers#410 The console package in vendor contains a big endian bug. The issue has already been solved in runc. See PRs: - opencontainers/runc#1727 - containerd/console#20 The console version has been updated from commit 84eeaae905 to commit 2748ece166 (commit that fixed the big-endian issue) The console package has been added in the Gopkg.toml because the console package is not directly used in the code and the dep command doesn't automatically update the console package. Signed-off-by: Alice Frosi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the console package for big-endian architectures.
When creating a new pty the returned path to the new pty slave was
wrong for the second und all subsequent ptys.
In runc the exec subcommand failed with an runtime error such as
container_linux.go:265: starting container process caused "open /dev/pts/4294967296: no such file or directory".The number is shifted by 32.
Signed-off-by: Peter Morjan [email protected]