remove placeholder for non-linux platforms #1654
Conversation
|
👍 |
dqminh
changed the title
runc currently only support Linux platform, and since we dont intend to expose the support to other platform, removing all other platforms placeholder code. `libcontainer/configs` still being used in https://github.com/moby/moby/blob/master/daemon/daemon_windows.go so keeping it for now. After this, we probably should also rename files to drop linux suffices if possible. Signed-off-by: Daniel Dao <[email protected]>
Signed-off-by: Daniel Dao <[email protected]>
|
Rebased. I think this should be fine to look at. I will send the rename of |
|
LGTM |
Is this by policy / lack of contributor support / lack of infra / logistics or something else? can you please elaborate on this please? I would like to see the feasibility of porting runc on AIX. I am interested and willing to contribute, if someone can provide little guidance. thanks! |
@gireeshpunathil From my POV its a little bit of everything. With majority of runc code only applicable to Linux, we think its easier for other platform implementations to being developed independently. With runc being an implementation of OCI spec now https://github.com/opencontainers/runtime-spec, the first step for that would be to add AIX support for the OCI spec. https://groups.google.com/a/opencontainers.org/forum/#!forum/dev would be a good place i think, or may be @estesp also has some pointers 😄 ! |
|
thanks @dqminh , I will digest the linked docs and see how and where to start. Will look forward for your support an guidance! |
We are planning to remove supports for non-Linux platform in runc (opencontainers/runc#1654). The current import here is the only thing that i found in docker that is windows-related so fixing this would remove the rest of windows code in runc. This changes some functions in daemon_windows to be the same as daemon_unix to use runtime-spec public API instead of runc. Signed-off-by: Daniel Dao <[email protected]>
|
LGTM |
We are planning to remove supports for non-Linux platform in runc (opencontainers/runc#1654). The current import here is the only thing that i found in docker that is windows-related so fixing this would remove the rest of windows code in runc. This changes some functions in daemon_windows to be the same as daemon_unix to use runtime-spec public API instead of runc. Signed-off-by: Daniel Dao <[email protected]>
We are planning to remove supports for non-Linux platform in runc (opencontainers/runc#1654). The current import here is the only thing that i found in docker that is windows-related so fixing this would remove the rest of windows code in runc. This changes some functions in daemon_windows to be the same as daemon_unix to use runtime-spec public API instead of runc. Signed-off-by: Daniel Dao <[email protected]> Upstream-commit: 4d1d486 Component: engine
runc currently only support Linux platform, and since we dont intend to expose
the support to other platform, removing all other platforms placeholder code.
libcontainer/configsstill being used in https://github.com/moby/moby/blob/master/daemon/daemon_windows.go sokeeping it for now.
cc @opencontainers/runc-maintainers @justincormack @jhowardmsft