-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: import umoci's release.sh script #1554
release: import umoci's release.sh script #1554
Conversation
In case you're wondering what the final release artifacts would look like for our last release, here they are:
The really nice thing is that it also provides a signed version of the source code (which is great for openSUSE because OBS supports verifying PGP signatures of source code automatically, but I'm fairly sure that most distributions will appreciate a signed source archive). Also, since Go supports reproducible builds natively, |
This new script is much nicer but the former |
@hqhq I don't think anyone actually wants that, I've personally never used it (nor have I ever actually published them either). Since we're statically compiling the binaries for release, we might as well enable everything. With the But if it's really necessary I can modify the script to do that (it will require some changes that I'll also include in |
@cyphar It's proposed in #899 /cc @crosbymichael should we keep building runc with different build configurations when |
Yeah, and I agreed to it in the past as well. I think I've changed my mind on this topic, after having published several releases, as well as my more recent experience on distribution-related stuff. |
I think its fine to have a single build now that most of the features are switched on via the spec. |
Im +1 for just doing a single build with all tags. |
And we expect distros that ship only selinux or apparmor to produce their own builds with only the features that they support right? This is more of our reference build of |
@cyphar OK, I'm +1 for single build as well, needs rebase. |
Yeah, distros should generally be building from source (and most importantly, they should be making it dynamically linked) so the binaries we ship aren't really relevant to them. The nice thing about Rebased. |
This script is far easier to use than the previous `make release` target, not to mention that it also automatically signs all of the artefacts and makes everything really easy to do for maintainers. Signed-off-by: Aleksa Sarai <[email protected]>
To make sure that `make release` doesn't suddenly break after we've cut a release, smoke-test the release scripts. The script won't fail if GPG keys aren't found, so running in CI shouldn't be a huge issue. Signed-off-by: Aleksa Sarai <[email protected]>
1 similar comment
/me rebuilds all of the latest releases with the new script. |
This script is far easier to use than the previous
make release
target, not to mention that it also automatically signs all of the
artefacts and makes everything really easy to do for maintainers.
[I'm going to re-release all of our previous releases using this script.]
Ref: openSUSE/umoci#163
Signed-off-by: Aleksa Sarai [email protected]