Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix condition to detect device type in DeviceFromPath #1544

Merged
merged 1 commit into from
Aug 5, 2017
Merged

Fix condition to detect device type in DeviceFromPath #1544

merged 1 commit into from
Aug 5, 2017

Conversation

mlaventure
Copy link
Contributor

@mlaventure mlaventure commented Aug 3, 2017 •
edited
Loading

Signed-off-by: Kenfe-Mickael Laventure [email protected]

--

Before this fix, /dev/fuse is created as a block device, and docker tries to create /dev/fd as a 0,0 device.

@mlaventure mlaventure mentioned this pull request Aug 3, 2017
Merged
@crosbymichael
Copy link
Member

crosbymichael commented Aug 3, 2017 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@thaJeztah
Copy link
Member

ping @cyphar PTAL

@mrunalp
Copy link
Contributor

mrunalp commented Aug 5, 2017 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@mrunalp mrunalp merged commit 135b999 into opencontainers:master Aug 5, 2017
@thaJeztah
Copy link
Member

Thanks @mrunalp !

@mlaventure mlaventure deleted the fix-device-from-path branch August 6, 2017 18:15
@mlaventure mlaventure mentioned this pull request Aug 9, 2017
Merged
@cyphar cyphar mentioned this pull request Feb 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mlaventure @crosbymichael @thaJeztah @mrunalp