Use symlink xattr functions from x/sys/unix #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8594 Update golang.org/x/sys to get the Lgetxattr, Llistxattr, Lremovexattr and Lsetxattr syscall wrappers. These will be used in a successive commit to replace the wrappers in libcontainer/system/xattr_linux.go. Signed-off-by: Tobias Klauser <[email protected]>
Use the symlink xattr syscall wrappers Lgetxattr, Llistxattr and Lsetxattr from x/sys/unix (introduced in golang/sys@b90f89a) instead of providing own wrappers. Leave the functionality of system.Lgetxattr intact with respect to the retry with a larger buffer, but switch it to use unix.Lgetxattr. Signed-off-by: Tobias Klauser <[email protected]>
|
LGTM. I should probably also move |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update x/sys/unix to get the symlink xattr syscall wrappers Lgetxattr, Llistxattr and Lsetxattr (introduced in
golang/sys@b90f89a) and switch libcontainer to use these instead of providing own wrappers.