Remove redundant declaration of namespace slice #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,12 +64,12 @@ func IsNamespaceSupported(ns NamespaceType) bool { | |||
|
|
|||
| func NamespaceTypes() []NamespaceType { | |||
| return []NamespaceType{ | |||
| NEWUSER, // Keep user NS always first, don't move it. | |||
There was a problem hiding this comment.
Can you finish re-ordering this list to match the one that was deleted?
Signed-off-by: Harshal Patil <[email protected]>
|
LGTM |
|
LGTM Thanks @harche |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespaces slice is declared twice. Let's keep list
namespaces at one place instead of duplicating it. Should
there be any change in future in the number of namespaces
or anything like that, we just have to change in one
location.
Signed-off-by: Harshal Patil [email protected]