Allow updating pids limit #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
crosbymichael
requested changes
Apr 27, 2017
update.go
Outdated
| @@ -228,6 +235,13 @@ other options are ignored. | |||
| *pair.dest = uint64(v) | |||
| } | |||
| } | |||
| if val := context.String("pids-limit"); val != "" { | |||
update.go
Outdated
| @@ -108,6 +108,10 @@ other options are ignored. | |||
| Name: "memory-swap", | |||
| Usage: "Total memory usage (memory + swap); set '-1' to enable unlimited swap", | |||
| }, | |||
| cli.StringFlag{ | |||
There was a problem hiding this comment.
I want int64 though, it doesn't exist unfortunately hence why the others are using StringFlag
mlaventure
force-pushed
the
update-pids-limit
branch
from
3ce94ec to
36dd49e
Compare
|
@mlaventure update test is broken |
Signed-off-by: Kenfe-Mickael Laventure <[email protected]>
mlaventure
force-pushed
the
update-pids-limit
branch
from
36dd49e to
1e7e276
Compare
|
ping @crosbymichael :) |
|
LGTM |
crosbymichael
approved these changes
Apr 28, 2017
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kenfe-Mickael Laventure [email protected]