add testcase in generic_error_test.go #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
mrunalp
reviewed
Apr 13, 2017
libcontainer/generic_error_test.go
Outdated
| } | ||
| } else { | ||
| if msg := err.Error(); msg == v.errmsg { | ||
| t.Fatalf("expected err msg %q but %q", msg, v.errmsg) |
There was a problem hiding this comment.
Here we are testing that they aren't equal but the message doesn't say that.
There was a problem hiding this comment.
@mrunalp
I haved changed the error messages.
chchliang
force-pushed
the
generictest
branch
3 times, most recently
from
cad9318 to
986dd34
Compare
|
LGTM |
mrunalp
reviewed
Apr 17, 2017
libcontainer/generic_error_test.go
Outdated
| t.Fatalf("expected err(%q) equal errmsg(%q)", msg, v.errmsg) | ||
| } | ||
| if v.cause != "" && msg == v.errmsg { | ||
| t.Fatalf("upexpected err(%q) equal errmsg(%q)", msg, v.errmsg) |
There was a problem hiding this comment.
typo: upexpected -> unexpected
There was a problem hiding this comment.
@mrunalp
I have modified. thanks!
Signed-off-by: chchliang <[email protected]>
|
LGTM. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add testcase with function
Error(),Code()in generic_error_test.goSigned-off-by: chchliang [email protected]