travis: use alternate commit range #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Batts <[email protected]>
|
oh boo. the new range includes merge commits ... hrm |
|
@mrunalp restart the travis check. I think i fixed it upstream |
|
@vbatts restarted build. |
|
@mrunalp it's green now |
|
LGTM |
|
LGTM |
|
It looks like this broke the Travis CI builds... |
|
@wking has opened issues to fix this
…On Tue, Mar 21, 2017 at 4:53 PM Aleksa Sarai ***@***.***> wrote:
It looks like this broke the Travis CI builds...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1382 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEF6dJBY-Hlst8cUiyflNYyTGUPe9djks5roDizgaJpZM4Mj1Bo>
.
|
|
On Tue, Mar 21, 2017 at 01:53:01PM -0700, Aleksa Sarai wrote:
It looks like this broke the Travis CI builds...
I think #1383 and vbatts/git-validation#17 will fix that, although
it's hard to test if TRAVIS_COMMIT_RANGE is only occasionally unset.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @mrunalp
I'm also going to try this as the upstream default vbatts/git-validation#15
Signed-off-by: Vincent Batts [email protected]