update go version at travis-ci #1335
Conversation
Signed-off-by: Máximo Cuadros <[email protected]>
|
Personally I would /prefer/ if we keep testing Go Unfortunately the failures on |
|
@cyphar I don't think we need to support go 1.6. If people are using it then it can be their responsibility. There are many improvements with 1.7-1.8 and security fixes that we can take advantage of. Also this is not a runtime issue, its a buildtime issue so its not an impact on users. Since we are pre 1.0 I think its an ok move to make, there is no reason to live on an old build of Go and not take advantage of the improvements. LGTM |
|
@crosbymichael Fair enough. LGTM. |
Closes #1335 LGTMs: @crosbymichael @cyphar
|
FWIW, you can have the best of both worlds. You can keep 1.6.x and any older Go releases as long as you only run tools like |
|
Compiling against old version of Go, IMHO, is a bad practice. We must help to the language evolve fast, updating to the latest versions ASAP. |
|
@mcuadros sure, but that's unrelated to supporting older Go versions :) Most projects support the last 2-3 minor releases, but you could just as well do 4 or more while adopting the newest version as soon as it's out. |
|
The problem is that go stdlib changes and when you use a new package it breaks older versions anyways. |
The helper DRYs up the transition tests and makes it easy to get complete coverage for invalid transitions. I'm also using t.Run() for subtests. Run() is new in Go 1.7 [1], but runc dropped support for 1.6 back in e773f96 (update go version at travis-ci, 2017-02-20, opencontainers#1335). [1]: https://blog.golang.org/subtests Signed-off-by: W. Trevor King <[email protected]>
The helper DRYs up the transition tests and makes it easy to get complete coverage for invalid transitions. I'm also using t.Run() for subtests. Run() is new in Go 1.7 [1], but runc dropped support for 1.6 back in e773f96 (update go version at travis-ci, 2017-02-20, opencontainers#1335). [1]: https://blog.golang.org/subtests Signed-off-by: W. Trevor King <[email protected]>
Travis is testing against 1.6.x and 1.7.x if the intent is test againts the last two stable version we should remove the 1.6 and add the 1.8
Also the tool being use for the validation of bash scripts (https://github.com/mvdan/sh) is only compatible with 1.7>
Also I added tip as an allowed to fail version