More fix to nsexec.c's comments #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyphar
reviewed
Nov 1, 2016
| * change the PID namespace of the calling process, because doing so | ||
| * would change the caller's idea of its own PID (as reported by getpid()), | ||
| * which would break many applications and libraries, so we must fork | ||
| * to actually enter the new PID namespace. |
There was a problem hiding this comment.
You don't really need to explain why the PID namespace is so funky. You can just say that we have to fork again to enter the PID namespace (even though we unshared it) because the PID namespace affects children only.
There was a problem hiding this comment.
I still got questions with comments like you said in out old implementation, so I think we can explain it clearly. It's not redundance for most of people.
|
LGTM. |
Signed-off-by: Qiang Huang <[email protected]>
mrunalp
reviewed
Nov 3, 2016
| * of the requested namespaces. If we've been asked to | ||
| * CLONE_NEWUSER, we will ask our parent (stage 0) to set up | ||
| * our user mappings for us. Then, we create a new child | ||
| * (stage 2: JUMP_INIT) for PID namespace's good. We then |
hqhq
force-pushed
the
fix_nsexec_comments
branch
from
1816ba3 to
84a4218
Compare
|
@mrunalp Updated. |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Qiang Huang [email protected]