Update blob patch status code to correct code #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PATCH blob upload endpoint returns a 202 Accepted when a chunk is accepted rather than a 204. The 204 is returned by the PUT endpoint after completion of an upload is successful. The status code in the detail section must match the protocol as described in the description for upload patching. It is stated at the beginning of the detail section that when the detail does not match, the description above it is correct. Signed-off-by: Derek McGowan <[email protected]>
4 tasks
|
LGTM |
|
Are we at a point where we could write a test for this? |
|
the tests in place do some, but not all. |
Is this actually true? AFAICT registries actually return a 201 here, and the spec has a similar discrepancy between the prose and the detail. |
|
@jonjohnsonjr you are right, that one has a mismatch as well. It seems the only 204 should be on the upload progress. Delete is also wrong. I'll open up a separate PR for those so the status codes can be evaluated separately. Ideally we can get rid of the disclaimer at the top of the detail section stating that it may be wrong :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PATCH blob upload endpoint returns a 202 Accepted when a chunk
is accepted rather than a 204. The 204 is returned by the PUT
endpoint after completion of an upload is successful. The status
code in the detail section must match the protocol as described
in the description for upload patching. It is stated at the beginning
of the detail section that when the detail does not match, the
description above it is correct.