skip TLS verification during conformance tests #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjasonh
requested review from
dmcgowan,
jzelinskie,
jonjohnsonjr,
jdolitsky,
mikebrow,
stevvooe,
sudo-bmitch and
vbatts
as code owners
jdolitsky
reviewed
Mar 22, 2023
jdolitsky
previously approved these changes
Mar 22, 2023
jdolitsky
previously approved these changes
Mar 22, 2023
|
Thanks @jdolitsky ! |
sudo-bmitch
requested changes
Apr 4, 2023
imjasonh
force-pushed
the
insecure-skip-tls-verify
branch
from
5f09a20 to
aab9867
Compare
jdolitsky
previously approved these changes
Apr 4, 2023
Signed-off-by: Jason Hall <[email protected]>
imjasonh
force-pushed
the
insecure-skip-tls-verify
branch
from
228e5be to
fa4a69a
Compare
jdolitsky
approved these changes
Apr 4, 2023
sudo-bmitch
approved these changes
Apr 4, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be useful in tests like this to point the test at an HTTPS endpoint, even though it won't actually serve valid HTTPS, for example because it's running in a test environment.
Making the test skip TLS verification should make it easier to run in such test environments. Conformance doesn't rely on TLS verification itself (explicitly, anyway), and any TLS configuration should be tested outside of OCI conformance, so I don't consider this a regression of the strictness of the test.