Define the representation for a tag name.

[briandealwis]

A tag is defined in the spec as a manifest identifier, but the spec does not define the acceptable representations for a tag. This PR provides a definition for the tag name based on the historical description from docker tag.

There was no reference to definitions for regular expressions, and other examples used basic regexs, so I didn't use character classes or bounds limits.

Motivated by #52

[jonjohnsonjr]

We might want to be a little more explicit around what the audience of the limitation. Clients need to know the allowed character set and maximum safe length for tags. Registries need to know the minimum length they need to support.

Clients: (1,128]

Registries: [128,Inf)

So... in order for clients to be able to use at most 128 characters, registries should support at least 128 characters.

We could also sidestep some of these questions with something like:

Throughout this document, `<reference>` must match the [grammar for digests](https://github.com/opencontainers/image-spec/blob/v1.0.1/descriptor.md#digests) or the following regular expression for tags:

`[\w][\w.-]{0,127}`

[mikebrow]

see comment regarding tag name as a term.

[briandealwis]

Oops sorry: these comments ended up in my hidden in my personal email.

@jonjohnsonjr I'm a bit hesitant:

• character set: should be brought in by reference to other standards documents such as HTTP (which defines that the URI and header block must be processed as octets encoded as a superset of US-ASCII).
• regex: there needs to be a reference to a specific form of regexs as POSIX regular expressions don't have \w, and RFCs usually use Augmented Backus-Naur Form (ABNF) notation specified in RFC2234. But your regexp showed me that my own regex was incorrect (ok for a tag to start with underscore).
• registries should support at least 128 characters: I'm a bit confused as 128,inf seems to imply that a registry must support tags that have a minimum of 128 characters?

[jonjohnsonjr]

seems to imply that a registry must support tags that have a minimum of 128 characters?

If registries don't support at least 128 characters in a tag, then they will be "broken" from the perspective of a client that expects to be able to use up to 128 characters.

It's basically Postel's Law: clients need to be conservative in what they do, and registries should be liberal in what they accept.

Is that a good idea? Who knows. The bare minimum, IMO, is that registries should support up to 128 characters. Given that clients are probably not prepared to deal with tags longer than 128 characters, maybe registries should also not support longer tags than that, but it seems a little bit limiting...

[mikebrow]

LGTM

[jonjohnsonjr]

LGTM but I'm not a maintainer :)

[waynr]

Looks good to me since it answers a question I brought up in slack. Not sure if I'm a maintainer on this project though -- probably not.

[vbatts]

@briandealwis your commit are missing DCO signature

[briandealwis]

Added a sign-off.

[vbatts]

🐙

[briandealwis]

Approval required by 1 of: @caniszczyk, @crosbymichael, @dmcgowan, @jdolitsky, @jzelinskie, @mikebrow, @stevvooe

[jzelinskie]

Looks really good in terms of keeping things surgical.