Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 405 Method Not Allowed for DELETE requests in teardowns #185

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Allow 405 Method Not Allowed for DELETE requests in teardowns #185

merged 1 commit into from
Oct 7, 2020

Conversation

markphelps
Copy link
Contributor

Fixes: #179

Allows 405 Method Not Allowed HTTP Response Status in teardown methods in conformance tests

Copy link
Member

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@markphelps
Copy link
Contributor Author

Thanks @jdolitsky, is there anything blocking this from being merged?

@jdolitsky
Copy link
Member

Hi, just waiting on another LGTM cc @opencontainers/distribution-spec-maintainers

@markphelps
Copy link
Contributor Author

@jdolitsky it doesnt seem that team @opencontainers/distribution-spec-maintainers exists anymore, is there perhaps someone individually that can take a look? thanks!

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdolitsky jdolitsky merged commit e6be018 into opencontainers:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conformance: Allow 405 Status for all tear down / deletes
3 participants