ERSPAN Mirror Session Enhancements #2142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ppanara-marvell <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
requested changes
Feb 25, 2025
Comment on lines
-1756
to
+1765
| META_MD_ASSERT_FAIL(md, "conditional attribute is also conditional, not allowed"); | ||
| if (md->objecttype == SAI_OBJECT_TYPE_MIRROR_SESSION && | ||
| (md->attrid == SAI_MIRROR_SESSION_ATTR_ERSPAN_SESSION_ID | ||
| || md->attrid == SAI_MIRROR_SESSION_ATTR_GRE_HEADER_FIRST_16BIT)) | ||
| { | ||
| /* | ||
| * ERSPAN_SESSION_ID is valid for ERSPAN and when encap_type is ERSPAN_II or ERSPAN_III | ||
| * GRE_HEADER_FIRST_16BIT is valid for ERSPAN encap_type GRE | ||
| */ | ||
| } |
There was a problem hiding this comment.
why this exception is made ?
There was a problem hiding this comment.
SAI_MIRROR_SESSION_ATTR_ERSPAN_ENCAPSULATION_TYPE values is added as validation for these attributes and SAI_MIRROR_SESSION_ATTR_ERSPAN_ENCAPSULATION_TYPE attribute itself is conditional.
There was a problem hiding this comment.
we probably should not have such dependencies
| /** | ||
| * @brief L3 GRE Tunnel Encapsulation | L2 Ethernet header | IP header | GRE header | ERSPAN (8B) | Original mirrored packet | ||
| */ | ||
| SAI_ERSPAN_ENCAPSULATION_TYPE_MIRROR_L3_GRE_TUNNEL_ERSPAN_TYPE_II, |
There was a problem hiding this comment.
This is a mouthful. Can we simply call it SAI_ERSPAN_ENCAPSULATION_TYPE_II?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update extends ERSPAN mirroring with added support for ERSPAN-II and ERSPAN-III. The key enhancements include: