-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static Member Selection Modes For ECMP and LAG #2078
base: master
Are you sure you want to change the base?
Static Member Selection Modes For ECMP and LAG #2078
Conversation
7a58a12
to
f0614a3
Compare
Summary of the discussion on 11/14/2024
Next steps agreed:[Ravi] and [Jai] to see if there are use-cases for enabling packet-spraying at a per NHG granularity instead of switch level. We should also see what happens to telemetry packets, control packets etc. We will discuss offline over the PR and if needed use a follow up meeting. |
@dkadia-marvell, @rck-innovium - any conclusion on this? does this need another discussion? |
f0614a3
to
030cdc9
Compare
inc/saiswitch.h
Outdated
@@ -187,6 +187,9 @@ typedef enum _sai_switch_switching_mode_t | |||
*/ | |||
typedef enum _sai_hash_algorithm_t | |||
{ | |||
/** Hash algorithm not set */ | |||
SAI_HASH_ALGORITHM_NONE = 7, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
place this between 6 and 8
030cdc9
to
8308989
Compare
0100e4d
to
16eddf6
Compare
Signed-off-by: dkadia-marvell <[email protected]>
16eddf6
to
b56e37f
Compare
Thanks @JaiOCP for the discussion. Please find the summary below: Summary of the follow-up discussion on 02/27/2025
|
/** | ||
* @brief End of Rule Actions | ||
*/ | ||
SAI_ACL_ENTRY_ATTR_ACTION_END = SAI_ACL_ENTRY_ATTR_ACTION_SET_INNER_DST_MAC, | ||
SAI_ACL_ENTRY_ATTR_ACTION_END = SAI_ACL_ENTRY_ATTR_ACTION_SET_ECMP_HASH_ALGORITHM, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should resign with setting this value explicitly, and just leave it as last attribute to not have to change that explicitly every time
This proposal introduces the below two types of light weight static member selection modes for ECMP/LAG.