Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of Device Manager with ODIM's services #52

Merged
merged 91 commits into from
Apr 25, 2023
Merged

Conversation

MaciejMis
Copy link
Collaborator

This pull request contains code related to integration between Device Manager and ODIM services moved into this project.
Most of the Device Manager code was rewritten. It connects with services via ODIM plugin interface using https.

Please note that most of the files changed comes from removing /vendor folder of Device Manager.
All code inside this PR was already reviewed on integration branch and the reviews can be found here but be welcomed to test and give us feedback!

Fixes:
#2
#19
#24
#29

Maciej Mis and others added 30 commits December 9, 2022 15:46
Signed-off-by: Maciej Mis <[email protected]>
Implement logger for requests.

Signed-off-by: Maciej Mis <[email protected]>
Implemented generic GET resource handler.
Implemented Validate endpoint.

Signed-off-by: Maciej Mis <[email protected]>
- Inlined timeNow variable,
- Removed comments.

Signed-off-by: Maciej Mis <[email protected]>
- New lines after curly brackets,
- New variable for error messages,
- Renamed uriTranslator to uriConverter.

Signed-off-by: Maciej Mis <[email protected]>
- Request logger expanded,
- Reset action implemented for ComputerSystem

Signed-off-by: Maciej Mis <[email protected]>
Integration with ODIM's services part #2
…WMgmt-DeviceMgr-DeviceManager into integration-https-server

� Conflicts:
�	src/config/config.go
�	src/config/config.yml

Signed-off-by: Maciej Mis <[email protected]>
Integration with ODIM's services part #3
…WMgmt-DeviceMgr-DeviceManager into integration-managers-collection

� Conflicts:
�	src/main.go
�	src/rest/getStatusHandler.go
Upgraded Go version to 1.17

Signed-off-by: Maciej Mis <[email protected]>
Signed-off-by: Maciej Mis <[email protected]>
Signed-off-by: Maciej Mis <[email protected]>
- Fixed NoContent not being accepted for Reset action,
- Request validation for ResetSystem action.

Signed-off-by: Maciej Mis <[email protected]>
Integration with ODIM's services part #7
Integration with ODIM's services part #8
Signed-off-by: Emilia Haligowska <[email protected]>
Maciej Mis added 19 commits March 24, 2023 16:31
Signed-off-by: Maciej Mis <[email protected]>
Signed-off-by: Maciej Mis <[email protected]>
Signed-off-by: Maciej Mis <[email protected]>
Signed-off-by: Maciej Mis <[email protected]>
Signed-off-by: Maciej Mis <[email protected]>
Signed-off-by: Maciej Mis <[email protected]>
Signed-off-by: Maciej Mis <[email protected]>
Signed-off-by: Maciej Mis <[email protected]>
Docker implementation for Device Manager
```shell
$ make all
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add paragraph - "Once that make is complete, the Redfish interface will be available at 127.0.0.1:45000. The port number is specified by the odimra_config.json file, property APIGatewayConf.Port. The Redfish interface is used to create a connection to Device Manager."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

ehaligow and others added 4 commits April 12, 2023 10:28
Signed-off-by: Emilia Haligowska <[email protected]>
…quoting

Fix for potentially unsafe quoting.
Signed-off-by: Maciej Mis <[email protected]>
Updated README for Docker integration
@MaciejMis MaciejMis merged commit 2537bad into main Apr 25, 2023
@MaciejMis
Copy link
Collaborator Author

This pull request was accepted on OpenRMC-DM meeting (25th April)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants