Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to GLPK configuration for MIPs #231

Merged
merged 2 commits into from
Mar 27, 2021
Merged

Improvements to GLPK configuration for MIPs #231

merged 2 commits into from
Mar 27, 2021

Conversation

cdiener
Copy link
Member

@cdiener cdiener commented Mar 18, 2021 •
edited
Loading

  • fix GLPK integer tolerance #223
  • description of feature/fix
    • enables setting the integrality threshold for GLPK again
    • changes the default for presolving for MIP problems in GLPK
      This is now the same default as in GLPK and is recommended since the MIP solver becomes very unstable otherwise.
    • made glpk_interface.py pep8 compliant
  • tests added/passed
  • add an entry to the next release

@cdiener cdiener changed the title Fix/glpk config Improvements to GLPK configuration for MIPs Mar 18, 2021
@Midnighter Midnighter mentioned this pull request Mar 22, 2021
Merged
Midnighter
Midnighter approved these changes Mar 27, 2021
View reviewed changes
Copy link
Member

@Midnighter Midnighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. I guess the functions glp_get_num_bin and glp_delete_prob were never really used?

@cdiener
Copy link
Member Author

cdiener commented Mar 27, 2021

Yeah and flake8 complained about that.

@cdiener cdiener merged commit 2848776 into opencobra:master Mar 27, 2021
This was referenced Sep 1, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Midnighter Midnighter Midnighter approved these changes

@carrascomj carrascomj Awaiting requested review from carrascomj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GLPK integer tolerance
2 participants
@cdiener @Midnighter