Remove old import and update import_tools #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlabadie
reviewed
Nov 29, 2021
There was a problem hiding this comment.
bug are not solve. When i test it. I get this error
KeyError: 1916:
File "C:\Users\mlabadie\Documents\GitHub\openalea-incubator\septo3d\SConstruct", line 16:
env = ALEASolution(options, tools)
File "c:\users\mlabadie\miniconda3\envs\septo3d\lib\site-packages\openalea.sconsx-2.2.6-py3.8.egg\openalea\sconsx\config.py", line 374:
compilerconf.UpdateOptions(compileroptions)
File "c:\users\mlabadie\miniconda3\envs\septo3d\lib\site-packages\openalea.sconsx-2.2.6-py3.8.egg\openalea\sconsx\config.py", line 301:
tool.option(opts)
File "c:\users\mlabadie\miniconda3\envs\septo3d\lib\site-packages\openalea.sconsx-2.2.6-py3.8.egg\openalea\sconsx\tools\compiler.py", line 120:
opts.Add(EnumVariable('MSVC_VERSION', 'Version ','' if not is_conda() else get_default_msvc(), allowed_values=sorted(MsvcVersion.values())+['']))
File "c:\users\mlabadie\miniconda3\envs\septo3d\lib\site-packages\openalea.sconsx-2.2.6-py3.8.egg\openalea\sconsx\tools\compiler.py", line 50:
return MsvcVersion[int(version)]
|
Could you give your version of MSVC? |
Visual Studio Community 2017 v15.9.41 |
|
OK. This version is not considered in sconsx.
I have to add it:
https://github.com/openalea/sconsx/blob/master/src/openalea/sconsx/tools/compiler.py#L34
Le 29/11/2021 à 15:02, Marc LABADIE a écrit :
…
Could you give your version of MSVC?
Visual Studio Community 2017 v15.9.41
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIR4STLOWXCKR57MPR4WX3UOOBZHANCNFSM5I26LXXA>.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
for information
|
|
I will update the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #49
Solve problem of build in septo3d