Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently name news accross the UI #13645

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Consistently name news accross the UI #13645

merged 1 commit into from
Jan 5, 2023

Conversation

dmarcoux
Copy link
Contributor

@dmarcoux dmarcoux commented Jan 5, 2023

Part of #13574

Renaming the internals like the model, controller and more is intentionally left out of this.

@github-actions github-actions bot added the Frontend Things related to the OBS RoR app label Jan 5, 2023
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #13645 (09be70b) into master (e126f33) will not change coverage.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13645   +/-   ##
=======================================
  Coverage   88.19%   88.19%           
=======================================
  Files         707      707           
  Lines       24221    24221           
=======================================
  Hits        21361    21361           
  Misses       2860     2860           

@hellcp-work
Copy link
Contributor

Maybe a better way to express it would be a news item instead of news when referring to an instance?

@dmarcoux
Copy link
Contributor Author

dmarcoux commented Jan 5, 2023

Maybe a better way to express it would be a news item instead of news when referring to an instance?

I don't really have a preference for this. Do you mean replacing something like Create News with Create News Item, and so on?

@hellcp-work
Copy link
Contributor

Yeah, I think that makes more sense than just "News" there

Part of #13574

Renaming the internals like the model, controller and more is
intentionally left out of this.
@dmarcoux dmarcoux requested a review from hellcp-work January 5, 2023 12:31
@dmarcoux
Copy link
Contributor Author

dmarcoux commented Jan 5, 2023

Please have another look @hellcp-work

@dmarcoux dmarcoux merged commit 62f9741 into openSUSE:master Jan 5, 2023
@dmarcoux dmarcoux deleted the issue-13574 branch January 5, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants