Update to Bootstrap 5 #13602
Merged
Update to Bootstrap 5 #13602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellcp-work
force-pushed
the
bs5
branch
5 times, most recently
from
610ea34 to
11fdbba
Compare
|
Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-bs5 |
hellcp-work
force-pushed
the
bs5
branch
2 times, most recently
from
e1f1afc to
c6e3658
Compare
hellcp-work
force-pushed
the
bs5
branch
4 times, most recently
from
68c948e to
9320a91
Compare
This was referenced Jan 4, 2023
hellcp-work
force-pushed
the
bs5
branch
2 times, most recently
from
3a5329a to
3395522
Compare
|
Another instance of a whitespace between icons on the project attributes page:
And more whitespace issues on the project pulse page since every link is underlined... it looks weird, especially for the headers:
There's also some missing margin/padding between the notifications and the user avatar at the top right: |
|
Looks like the delete file button in the Package show page is not working: |
It no longer has a default, so we have to set this up manually
We avoid the test on mobile because of the issue mentioned in the comment
Looks like it's fixed! 👍 |
danidoni
approved these changes
Jan 12, 2023
dmarcoux
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite big, but also not really possible to break up into smaller pieces. I have made sure to split this up into reasonable commits, so that you can check out the individual changes in order, hopefully making this easier to review
Depends on #13617