Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop 1.70.0 → 1.71.2 (minor) #262

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Feb 5, 2025

👉 This PR is queued up to get rebased by Depfu

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (1.70.0 → 1.71.2) · Repo · Changelog

Release Notes

1.71.2

Bug fixes

  • #13782: Fix an error Layout/ElseAlignment when else is part of a numblock. (@earlopain)
  • #13395: Fix a false positive for Lint/UselessAssignment when assigning in branch and block. (@pCosta99)
  • #13783: Fix a false positive for Lint/Void when each numblock with conditional expressions that has multiple statements. (@earlopain)
  • #13787: Fix incorrect autocorrect for Style/ExplicitBlockArgument when using arguments of zsuper in method definition. (@koic)
  • #13785: Fix Style/EachWithObject cop error in case of single block argument. (@viralpraxis)
  • #13781: Fix a false positive for Lint/UnmodifiedReduceAccumulator when omitting the accumulator in a nested numblock. (@earlopain)

1.71.1

Bug fixes

  • #10081: Add the missing include RuboCop::RSpec::ExpectOffense in rubocop/rspec/support.rb. (@d4rky-pl)
  • #13765: Fix a false negative for Lint/AmbiguousBlockAssociation with numblocks. (@earlopain)
  • #13759: Fix a false negative for Lint/ConstantDefinitionInBlock with numblocks. (@earlopain)
  • #13741: Register an offense for Naming/BlockForwarding and Style/ArgumentsForwarding with Ruby >= 3.4 when the block argument is referenced inside a block. This was previously disabled because of a bug in Ruby 3.3.0. (@earlopain)
  • #13777: Fix a false negative for Layout/EmptyLineBetweenDefs with DefLikeMacros and numblocks. (@earlopain)
  • #13769: Fix a false negative for Style/RedundantParentheses with numblocks. (@earlopain)
  • #13780: Fix a false positive Style/AccessModifierDeclarations when using access modifier in a numblock. (@earlopain)
  • #13775: Fix a false positive for Lint/AssignmentInCondition when assigning in numblocks. (@earlopain)
  • #13773: Fix false positives for Layout/RedundantLineBreak when using numbered block parameter. (@koic)
  • #13761: Fix a false positive for Style/SuperArguments when calling super in a numblock. (@earlopain)
  • #13768: Fix a false positive for Lint/UnreachableCode with instance_eval numblock. (@earlopain)
  • #13750: Fix false positives for Style/RedundantSelfAssignment when assigning to attribute of self. (@koic)
  • #13739: Fix false positive for Style/HashExcept and Style/HashSlice when checking for inclusion with a range. (@dvandersluis)
  • #13751: Fix false positive in Layout/ExtraSpacing with ForceEqualSignAlignment: true for endless methods. (@dvandersluis)
  • #13767: Fix Style/IdenticalConditionalBranches autocorrect when condition is inside assignment. (@dvandersluis)
  • #13764: Fix a false negative for Layout/SingleLineBlockChain with numblocks. (@earlopain)
  • #13771: Fix wrong autocorrect for Style/SoleNestedConditional when using numblocks. (@earlopain)

1.71.0

New features

Bug fixes

  • #13684: Fix a false positive for Style/FrozenStringLiteralComment when using the frozen string literal magic comment in Active Admin's arb files. (@koic)
  • #13372: Add rubocop_cache to the path given by --cache-root when pruning cache. (@capncavedan)
  • #13257: Fix department disable/enable comments enabling the cop for the whole file even if that file is excluded by the cop. (@earlopain)
  • #13704: Fix false positives for Lint/OutOfRangeRegexpRef when matching with match using safe navigation. (@koic)
  • #13720: Fix false positives for Style/BlockDelimiters when using brace blocks as conditions under EnforcedStyle: semantic. (@koic)
  • #13688: Fix false negative on Style/RedundantLineContinuation when the continuation is preceded by an interpolated string. (@dvandersluis)
  • #13677: Fix false negative on Style/RedundantLineContinuation when the continuation is followed by a percent array. (@dvandersluis)
  • #13692: Fix false positive in Style/RedundantLineContinuation when the ruby code ends with a commented continuation. (@dvandersluis)
  • #13675: Fix invalid autocorrect for Style/ArrayFirstLast when calling .[] or &.[] with 0 or -1. (@dvandersluis)
  • #13685: Fix syntax error introduced by Lint/SafeNavigationChain when adding safe navigation to an operator call inside a hash. (@dvandersluis)
  • #13725: Fix an incorrect autocorrect for Style/IfUnlessModifier when using omitted hash values in an assignment. (@elliottt)
  • #13667: Maintain precedence in autocorrect for Style/SoleNestedConditional. (@tejasbubane)
  • #13679: Fix false positive for Style/RedundantLineContinuation when calling methods with fully qualified constants. (@earlopain)
  • #13728: Fix a RuboCop error on provided glob pattern which matches directory. (@viralpraxis)
  • #13693: Fix Style/ConditionalAssignment cop error on unless without else and assign_inside_condition enforced style. (@viralpraxis)
  • #13669: Fix Style/FrozenStringLiteralComment cop error on unnormalized magic comment and never enforced style. (@viralpraxis)
  • #13696: Update Metrics/CollectionLiteralLength to only register for [] when called on Set. (@dvandersluis)

Changes

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ language_server-protocol (indirect, 3.17.0.3 → 3.17.0.4) · Repo · Changelog

Release Notes

3.17.0.4 (from changelog)

  • Add #close to Reader and Writer (#112)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ parser (indirect, 3.3.6.0 → 3.3.7.1) · Repo · Changelog

Release Notes

3.3.7.0 (from changelog)

API modifications:

  • Bump maintenance branches to 3.3.7 (#1061) (Koichi ITO)
  • bump 3.4 branch, remove 3.0 from CI (EOL) (#1057) (Ilya Bylich)
  • assert that version-specific checks actually run against at least one version (#1050) (Earlopain)

Features implemented:

  • ruby34.y: reject return in singleton class (#1048) (Earlopain)

Bugs fixed:

  • Fix ruby-parse with a folder ending in .rb (#1047) (Earlopain)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 15 commits:

↗️ rubocop-ast (indirect, 1.37.0 → 1.38.0) · Repo · Changelog

Release Notes

1.38.0 (from changelog)

New features

  • #346: Add Node#loc? to determine if a node has a given location. (@dvandersluis)
  • #356: Added :any_block as an alias for :block and :numblock, use it with Node#any_block_type?. Also available in node patterns: {block numblock} can become any_block. (@earlopain)

Bug fixes

  • #323: Fix node captures inside of ?, +, and * repetition. (@earlopain)

Changes

  • #357: Support node groups in Node#each_descendant and similar traversal methods. (@earlopain)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 24 commits:

↗️ unicode-display_width (indirect, 3.1.3 → 3.1.4) · Repo · Changelog

Release Notes

3.1.4 (from changelog)

  • Fix that skin tone modifiers were ignored when used in a non-ZWJ sequence context (= single emoji char + modifier) #29
  • Add more docs and specs about modifier handling

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 3 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Feb 5, 2025
Copy link
Contributor Author

depfu bot commented Feb 6, 2025

Closing because this update has already been applied

@depfu depfu bot closed this Feb 6, 2025
@depfu depfu bot deleted the depfu/update/rubocop-1.71.2 branch February 6, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants