-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Nomad Docs #660
Improve Nomad Docs #660
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
=======================================
Coverage 76.19% 76.19%
=======================================
Files 43 43
Lines 3592 3592
=======================================
Hits 2737 2737
Misses 625 625
Partials 230 230 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind to copy the table added in #651 (comment)? This might be helpful and summarizes our findings.
Further, I was wondering about a "consequence" after a problematic restart. Shouldn't be there some note on the runner being clean / used / marked as used (in case an agent is restarted)? And maybe a word on the coupling of the Nomad service and Docker service that we added (to restart one if the other restarts). For servers, I would love to see another sentence about reconnecting, recovering the event stream, ...
By the way, the event stream usage (the why, the benefits, the pitfalls) is not yet documented here either, is it? Just saying that this might be useful, too, especially as a handover.
d5b8fab
to
7d528a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, so much! This makes the documentation much more valuable and I you greatly addressed all my previous review points. A few minor comments left, but nothing big.
I am continue to feed my issue #669, but I assume those should be fixed soon with your latest PR. |
255e173
to
31134cb
Compare
ee7d2c7
to
22f377b
Compare
to describe the behavior of running executions during Nomad restarts. Co-authored-by: Sebastian Serth <[email protected]>
22f377b
to
f72f611
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to write additional documentation; I really appreciate it! 🌍
to describe the behavior of running executions during Nomad restarts.
Related to #651