Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add array_interpolate_linear process #44

Merged
merged 4 commits into from
Mar 9, 2022

Conversation

zcernigoj
Copy link
Contributor

@zcernigoj zcernigoj commented Mar 1, 2022

https://git.sinergise.com/team-6/openeo-platform/-/issues/97

docs: https://docs.openeo.cloud/processes/?#array_interpolate_linear

A return type in the docs is number|null but there is nothing about propagating null if the array is null or empty (like for some of the other processes). So, I'm not sure.

@zcernigoj zcernigoj changed the title add array_interpolate_linear process and tests add array_interpolate_linear process Mar 2, 2022
@dgostencnik dgostencnik self-assigned this Mar 2, 2022
@dgostencnik
Copy link
Contributor

I think the return type should be array<number|null>. For empty array I'd assume empty array is returned, for null probably null. Perhaps open an issue for that in openeo-processes repo

@dgostencnik dgostencnik assigned zcernigoj and unassigned dgostencnik Mar 2, 2022
@zcernigoj
Copy link
Contributor Author

I think the return type should be array<number|null>. For empty array I'd assume empty array is returned, for null probably null. Perhaps open an issue for that in openeo-processes repo

opened an issue: Open-EO/openeo-processes#333

@zcernigoj
Copy link
Contributor Author

I think the return type should be array<number|null>. For empty array I'd assume empty array is returned, for null probably null. Perhaps open an issue for that in openeo-processes repo

opened an issue: Open-EO/openeo-processes#333

Nothing to change as it already behaves as it should.

@zcernigoj zcernigoj merged commit 6c3a1d3 into master Mar 9, 2022
@zcernigoj zcernigoj deleted the add/array_interpolate_linear-process branch March 9, 2022 14:19
@zcernigoj zcernigoj restored the add/array_interpolate_linear-process branch March 9, 2022 14:19
@zcernigoj zcernigoj deleted the add/array_interpolate_linear-process branch March 9, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants