Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terminology data to release 2.4.0 #619

Merged
merged 5 commits into from
Aug 8, 2024
Merged

Update terminology data to release 2.4.0 #619

merged 5 commits into from
Aug 8, 2024

Conversation

J3173
Copy link
Collaborator

@J3173 J3173 commented Aug 8, 2024

Update the terminology information to release 2.4.0

This uses the XML files from https://github.com/openEHR/specifications-TERM/tree/Release-2.4.0/computable/XML with two modifications:

  • Re-enabled the MultiMedia group not to cause breaking changes, as these codes are still used in older archetypes
  • ids (re-)added to groups so groups can be matched across different languages
    • The previous group ids of two groups in the Japanese language file contained typos, these are also fixed.

The fullTermFile.json is regenerated according to the README and tests are updated to match the changes in the terminology files.

The terminology information is not yet updated to release 3.0.0 as it contains breaking changes. This should probably be done in a major version update of Archie itself.

@J3173 J3173 self-assigned this Aug 8, 2024
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.97%. Comparing base (0e79616) to head (1f68923).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #619      +/-   ##
============================================
+ Coverage     71.91%   71.97%   +0.06%     
- Complexity     7055     7085      +30     
============================================
  Files           671      671              
  Lines         23015    23083      +68     
  Branches       3736     3761      +25     
============================================
+ Hits          16551    16615      +64     
  Misses         4717     4717              
- Partials       1747     1751       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@J3173 J3173 requested a review from MattijsK August 8, 2024 13:08
Copy link
Collaborator

@MattijsK MattijsK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is indeed not a huge change.

@J3173 J3173 merged commit 8df5c64 into master Aug 8, 2024
6 checks passed
@J3173 J3173 deleted the terminology-2.4.0 branch August 8, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants