Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stability on attributes and events #568

Merged

Conversation

jerbly
Copy link
Contributor

@jerbly jerbly commented Jan 23, 2025

For issue #564

Added warnings for missing stability on:

  • Attributes
  • Enum members in attributes
  • Event AnyValues
  • Enum members in AnyValues

@jerbly jerbly requested review from a team as code owners January 23, 2025 21:32
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 65.99327% with 101 lines in your changes missing coverage. Please review.

Project coverage is 73.6%. Comparing base (d2e8947) to head (5aaec64).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
crates/weaver_resolved_schema/src/lib.rs 68.0% 45 Missing ⚠️
crates/weaver_semconv/src/deprecated.rs 52.3% 20 Missing ⚠️
crates/weaver_common/src/result.rs 0.0% 18 Missing ⚠️
crates/weaver_otel_schema/src/lib.rs 43.7% 9 Missing ⚠️
crates/weaver_resolved_schema/src/catalog.rs 60.0% 4 Missing ⚠️
crates/weaver_common/src/diagnostic.rs 0.0% 2 Missing ⚠️
crates/weaver_resolver/src/registry.rs 84.6% 2 Missing ⚠️
crates/weaver_cache/src/lib.rs 80.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #568     +/-   ##
=======================================
- Coverage   74.5%   73.6%   -1.0%     
=======================================
  Files         51      55      +4     
  Lines       3965    4425    +460     
=======================================
+ Hits        2957    3259    +302     
- Misses      1008    1166    +158     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you so much!

Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schema changes LGTM!

@lquerel lquerel enabled auto-merge (squash) January 30, 2025 04:26
@lquerel lquerel merged commit 28bbc0f into open-telemetry:main Feb 5, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants