-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: common resolve registry with policy checks #536
Refactor: common resolve registry with policy checks #536
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
=======================================
- Coverage 74.5% 74.5% -0.1%
=======================================
Files 51 51
Lines 3960 3960
=======================================
- Hits 2954 2953 -1
- Misses 1006 1007 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, really great cleanup!!! Just want to check on some functionality that may have also not been consistent across commands.
Great cleanup, and thank you for doing that! |
generate
,resolve
andcheck
.after_resolution
policy checks togenerate
andresolve
through the common code.--registry-git-sub-dir
option.check
if--skip-policies
was specified then it would not fail for any validation errors. e.g. this failsregistry check -r "https://github.com/open-telemetry/semantic-conventions/archive/refs/tags/v1.27.0.zip[model]" --future
but this would passregistry check -r "https://github.com/open-telemetry/semantic-conventions/archive/refs/tags/v1.27.0.zip[model]" --future --skip-policies