Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semconv schema to define stability as optional for attribute groups. #467

Merged
merged 12 commits into from
Nov 23, 2024

Conversation

jerbly
Copy link
Contributor

@jerbly jerbly commented Nov 19, 2024

@lmolkova wrote:

... the attribute_group stability does not make sense - https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/group-stability.md#group-stability. It'd be really awesome if we changed yaml schema and tooling behind it to reflect this

This change updates the semconv schema and the syntax doc to correctly define stability as optional for attribute groups.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.5%. Comparing base (cab3125) to head (b65bfc2).

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #467     +/-   ##
=======================================
- Coverage   72.5%   72.5%   -0.1%     
=======================================
  Files         49      49             
  Lines       3635    3635             
=======================================
- Hits        2639    2638      -1     
- Misses       996     997      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jerbly jerbly force-pushed the schema-group-stability branch from 1785a7d to b65bfc2 Compare November 19, 2024 14:04
Comment on lines +460 to +466
},
"stability": {
"allOf": [
{
"$ref": "#/$defs/StabilityLevel"
}
]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that AttributeFullSpec had stability as required but without the property!

@jerbly jerbly marked this pull request as ready for review November 19, 2024 14:10
@jerbly jerbly requested review from a team as code owners November 19, 2024 14:10
schemas/semconv-syntax.md Show resolved Hide resolved
@jerbly jerbly requested a review from lquerel November 22, 2024 14:39
Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@lquerel lquerel merged commit 1529f30 into open-telemetry:main Nov 23, 2024
23 checks passed
@jerbly jerbly deleted the schema-group-stability branch November 23, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants