-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update semconv schema to define stability
as optional for attribute groups.
#467
Conversation
…as optional for attribute groups.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
=======================================
- Coverage 72.5% 72.5% -0.1%
=======================================
Files 49 49
Lines 3635 3635
=======================================
- Hits 2639 2638 -1
- Misses 996 997 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…as optional for attribute groups.
1785a7d
to
b65bfc2
Compare
}, | ||
"stability": { | ||
"allOf": [ | ||
{ | ||
"$ref": "#/$defs/StabilityLevel" | ||
} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that AttributeFullSpec
had stability
as required but without the property!
…aver into schema-group-stability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
@lmolkova wrote:
This change updates the semconv schema and the syntax doc to correctly define
stability
as optional for attribute groups.