Let policy flag accept directories. #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lquerel
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Overall, LGTM. Thank you for this contribution. I made a few suggestions. Before merging, could you also update the comment on lines 35-36 in src/registry/check.rs with the following text: ‘List policy files or directories containing policy files to verify against the semantic convention registry.’ There are other sub-commands like generate, resolve, etc., where you should also make this change. Thanks.
crates/weaver_checker/src/lib.rs
Outdated
| assert_eq!(1, engine.policy_package_count); | ||
|
|
||
| _ = engine.add_policy_from_file_or_dir("data/multi-policies")?; | ||
| // TODO: add_policies double counts the number of files it adds. |
There was a problem hiding this comment.
Indeed, there is double counting in add_policies. It would be good to take advantage of this PR to fix the bug. Thank you.
Co-authored-by: Laurent Quérel <[email protected]>
Updated policy flag documentation.
Merged
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #259
This change allows --policy flags to accept a directory and include any *.rego file found. It does not recurse into sub directories.