Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): Add attribute_sort filter to weaver_forge #144

Merged
merged 4 commits into from
May 3, 2024

Conversation

jsuereth
Copy link
Contributor

@jsuereth jsuereth commented May 3, 2024

Add a filter that lets us perform attribute sorting the way we need to for semconv templates.

Also document other filters/tests added previously.

jsuereth added 2 commits May 2, 2024 23:01
Add a filter that lets us perform attribute sorting the way we need to for semconv templates.

Also document other filters/tests added previously.
@jsuereth jsuereth requested a review from lquerel as a code owner May 3, 2024 03:04
Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 75.5%. Comparing base (261e4f4) to head (879fed2).

❗ Current head 879fed2 differs from pull request most recent head 8f983ea. Consider uploading reports for the commit 8f983ea to get more accurate results

Files Patch % Lines
crates/weaver_forge/src/extensions/otel.rs 90.6% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #144     +/-   ##
=======================================
+ Coverage   75.3%   75.5%   +0.2%     
=======================================
  Files         42      42             
  Lines       2367    2400     +33     
=======================================
+ Hits        1783    1813     +30     
- Misses       584     587      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a suggestion you could integrate before to merge this PR.
As, it's not blocking, I approved the PR.

crates/weaver_forge/src/extensions/otel.rs Outdated Show resolved Hide resolved
@jsuereth jsuereth merged commit 4d0b8bd into open-telemetry:main May 3, 2024
17 checks passed
@jsuereth jsuereth deleted the feature-attribute-sort branch May 3, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants