-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate markdown snippets using weaver_forge templates #141
Merged
jsuereth
merged 11 commits into
open-telemetry:main
from
jsuereth:snippet-gen-used-forge
May 2, 2024
Merged
Generate markdown snippets using weaver_forge templates #141
jsuereth
merged 11 commits into
open-telemetry:main
from
jsuereth:snippet-gen-used-forge
May 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a prototype where markdown snippets are generated using Jinja / weaver_forge. - Fix an issue in cache/git resolver now that semconv repo has non-model yaml files. - Add new hooks in weaver_forge for generating just strings from templates. - Add optional weaver_forge support to weaver_semconv_gen for snippet generation. Lots of things that should be config are still hardcoded.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
=======================================
+ Coverage 71.9% 74.8% +2.8%
=======================================
Files 40 40
Lines 2208 2288 +80
=======================================
+ Hits 1589 1712 +123
+ Misses 619 576 -43 ☔ View full report in Codecov by Sentry. |
- Update to only use ONE snippet template for all snippets. - Update context for snippets to include attribute registry base url - Update documentation.
jsuereth
changed the title
Prototype snippets on templates
Generate markdown snippets using weaver_forge templates
May 2, 2024
lquerel
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117
Add an option where markdown snippets are generated using Jinja / weaver_forge.
Example:
This will look for a jinja template
templates/registry/markdown/snippet.md.j2
and use it to generate markdown snippets instead of hardcodedwrite!
statements.