Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving android to the registry attributes #544

Merged
merged 12 commits into from
Mar 6, 2024

Conversation

mlunadia
Copy link
Contributor

moving android to the registry attributes

@mlunadia mlunadia requested review from a team November 20, 2023 11:58
@ChrsMark ChrsMark requested review from a team and AlexanderWert November 20, 2023 13:44
Copy link
Contributor

@trisch-me trisch-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending, @AlexanderWert's suggestion on the registry markdown.

@AlexanderWert
Copy link
Member

AlexanderWert commented Dec 8, 2023

There's an additional Android attribute in here: https://github.com/open-telemetry/semantic-conventions/blob/main/model/logs/mobile-events.yaml

Should we move that (and maybe also the iOS one) as part of this PR as well?

EDIT: Actually that would be yet another case being blocked on open-telemetry/build-tools#242, because we would mix resource with semantic attributes.

@mlunadia
Copy link
Contributor Author

mlunadia commented Dec 8, 2023

There's an additional Android attribute in here: https://github.com/open-telemetry/semantic-conventions/blob/main/model/logs/mobile-events.yaml

Should we move that (and maybe also the iOS one) as part of this PR as well?

EDIT: Actually that would be yet another case being blocked on open-telemetry/build-tools#242, because we would mix resource with semantic attributes.

@AlexanderWert should we go ahead and merge the PR as it is today to progress on the attributes that are not blocked?

Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 25, 2024
@breedx-splk
Copy link
Contributor

@mlunadia Looks like this needs a rebase. Also commenting to keep this open because I think we're close?

@breedx-splk breedx-splk removed the Stale label Jan 26, 2024
@trisch-me
Copy link
Contributor

@mlunadia could you please update this PR with fields @AlexanderWert mentioned above and change the type to be generic attribute_group.

Copy link

github-actions bot commented Mar 2, 2024

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 2, 2024
@ChrsMark ChrsMark removed the Stale label Mar 5, 2024
@ChrsMark
Copy link
Member

ChrsMark commented Mar 5, 2024

@open-telemetry/specs-semconv-approvers do we need a changelog for this or we can label with "Skip Changelog"?

@trisch-me trisch-me added the Skip Changelog Label to skip the changelog check label Mar 5, 2024
@trisch-me
Copy link
Contributor

@ChrsMark yes, we don't need a changelog entry for refactoring, I have added a label

@ChrsMark
Copy link
Member

ChrsMark commented Mar 5, 2024

@ChrsMark yes, we don't need a changelog entry for refactoring, I have added a label

Cool, then I guess this is good to go? Do not see anything else pending here 🤔

@joaopgrassi joaopgrassi merged commit 153b768 into open-telemetry:main Mar 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Label to skip the changelog check
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants