-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moving android to the registry attributes #544
Conversation
Signed-off-by: Miguel Luna <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good pending, @AlexanderWert's suggestion on the registry markdown.
amending title
adding omit_requirement_level
There's an additional Android attribute in here: https://github.com/open-telemetry/semantic-conventions/blob/main/model/logs/mobile-events.yaml Should we move that (and maybe also the iOS one) as part of this PR as well? EDIT: Actually that would be yet another case being blocked on open-telemetry/build-tools#242, because we would mix resource with semantic attributes. |
Signed-off-by: Miguel Luna <[email protected]>
@AlexanderWert should we go ahead and merge the PR as it is today to progress on the attributes that are not blocked? |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
@mlunadia Looks like this needs a rebase. Also commenting to keep this open because I think we're close? |
@mlunadia could you please update this PR with fields @AlexanderWert mentioned above and change the type to be generic |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
@open-telemetry/specs-semconv-approvers do we need a changelog for this or we can label with "Skip Changelog"? |
@ChrsMark yes, we don't need a changelog entry for refactoring, I have added a label |
Cool, then I guess this is good to go? Do not see anything else pending here 🤔 |
moving android to the registry attributes