-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging events domain and name #473
Merging events domain and name #473
Conversation
Co-authored-by: jason plumb <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, and matches what we talked about in the sig meeting. Do the protobuf definitions also need to change accordingly? Can we link to that work or create a follow-up issue? Thanks! 🙏🏻
I don't see events in the protobuf definitions repo. I may be blind so could you drop me a link? If it's not there, we should get a ticket created to make the protobuf definition. |
The PR needs a description that explains why the change is made, the motivation and reasoning. It links to issue #2994 which does not exist in this repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am temporarily blocking the PR to give time to @scheler as they requested: open-telemetry/opentelemetry-specification#2994 (comment)
@scheler please comment on how much time you think you need.
The work on this PR can continue, it is a temporary block to avoid premature merging.
Co-authored-by: Tigran Najaryan <[email protected]>
Removing my block after confirming with @scheler
@breedx-splk I believe we are good to go now. |
My request to link to main branch was wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the links to the spec repo to use the correct tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but the PR does more things then it says in the description. It also adds the device
prefix, which I couldn't find any decision or discussion about it in the comments (maybe I missed it?)
I saw this issue #548 which opens the discussion but also no conclusion. Since this has several approvals, is everyone OK with this change as well? Is everyone aware of this?
@joaopgrassi Actually it does not add the device prefix, but for mobile merges the I'd like to keep #548 separate from this PR, that would change the prefix from |
Co-authored-by: jason plumb <[email protected]> Co-authored-by: Tigran Najaryan <[email protected]> Co-authored-by: jack-berg <[email protected]> Co-authored-by: Joao Grassi <[email protected]> Co-authored-by: Alexander Wert <[email protected]>
Fixes #2994
Changes
Merging the
domain
andname
fields for events and modifying language to refer to the first part of the name asnamespace
. This more closely aligns the semantic conventions ofevents
withmetrics
as we have discussed during the events working group meeting.The spec update pull request is here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist