Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved network attributes to the registry #390

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Moved network attributes to the registry #390

merged 2 commits into from
Oct 19, 2023

Conversation

AlexanderWert
Copy link
Member

@AlexanderWert AlexanderWert commented Oct 12, 2023 •
edited
Loading

Changes

Refactoring: moves network.* attributes to the attributes registry

Merge requirement checklist

@AlexanderWert AlexanderWert requested review from a team October 12, 2023 08:42
ChrsMark
ChrsMark approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ChrsMark ChrsMark mentioned this pull request Oct 19, 2023
Open
68 tasks
@joaopgrassi joaopgrassi merged commit 315a429 into open-telemetry:main Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@trisch-me trisch-me trisch-me approved these changes

@ChrsMark ChrsMark ChrsMark approved these changes

@pyohannes pyohannes pyohannes approved these changes

Assignees

@reyang reyang

Labels
None yet
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AlexanderWert @joaopgrassi @trisch-me @ChrsMark @pyohannes @reyang