Fix links #1814
Open
Fix links #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
commented
Jan 24, 2025
| @@ -23,10 +23,10 @@ linkTitle: Generative AI events | |||
|
|
|||
| <!-- tocstop --> | |||
|
|
|||
| GenAI instrumentations MAY capture user inputs sent to the model and responses received from it as [events](https://github.com/open-telemetry/opentelemetry-specification/tree/v1.41.0/specification/logs/api.md#emit-an-event). | |||
| GenAI instrumentations MAY capture user inputs sent to the model and responses received from it as [events](../general/events.md). | |||
There was a problem hiding this comment.
@lmolkova alternatively could do
Suggested change
| GenAI instrumentations MAY capture user inputs sent to the model and responses received from it as [events](../general/events.md). | |
| GenAI instrumentations MAY capture user inputs sent to the model and responses received from it as [events](https://github.com/open-telemetry/opentelemetry-specification/tree/v1.41.0/specification/logs/api.md#emit-a-logrecord). |
There was a problem hiding this comment.
Let's link the events section there?
Suggested change
| GenAI instrumentations MAY capture user inputs sent to the model and responses received from it as [events](../general/events.md). | |
| GenAI instrumentations MAY capture user inputs sent to the model and responses received from it as [events](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.41.0/specification/logs/data-model.md#events). |
trask
commented
Jan 24, 2025
chalin
approved these changes
Jan 24, 2025
|
Note that the patching done via Is minimal to ensure that the link checker is happy. I haven't matched all the changes proposed in this PR. (Probably what you already expect, but wanted to make that explicit.) |
lmolkova
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link checker isn't checking anchors on external links, I've opened #1813 to look into (and hopefully fix) the underlying issue in lychee, but fixing the links @chalin has found via the website link checker in the meantime...