Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint fixes from open collector-contrib PRs. #188

Merged
merged 2 commits into from
May 9, 2024

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented May 9, 2024

Minor lint fixes needed to keep the two code-bases in sync.

  • Remove unused context argument from nextWriter()
  • Do not name a field N
  • Fix unused variable rnd
  • Harden the stream-lifetime test w/ use of context
  • Etc.

@jmacd jmacd merged commit f8c64ed into open-telemetry:main May 9, 2024
2 checks passed
@jmacd jmacd mentioned this pull request May 9, 2024
jmacd added a commit that referenced this pull request May 9, 2024
Included PRs:
- #174
- #181
- #184
- #186
- #188

---------

Co-authored-by: Joshua MacDonald <[email protected]>
@jmacd jmacd deleted the jmacd/lint branch May 9, 2024 19:30
codeboten referenced this pull request in open-telemetry/opentelemetry-collector-contrib May 14, 2024
…or to v0.23.0 (#33055)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/open-telemetry/otel-arrow/collector](https://github.com/open-telemetry/otel-arrow)
| `v0.22.0` -> `v0.23.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fopen-telemetry%2fotel-arrow%2fcollector/v0.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fopen-telemetry%2fotel-arrow%2fcollector/v0.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fopen-telemetry%2fotel-arrow%2fcollector/v0.22.0/v0.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fopen-telemetry%2fotel-arrow%2fcollector/v0.22.0/v0.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>open-telemetry/otel-arrow
(github.com/open-telemetry/otel-arrow/collector)</summary>

###
[`v0.23.0`](https://github.com/open-telemetry/otel-arrow/releases/tag/v0.23.0)

[Compare
Source](https://github.com/open-telemetry/otel-arrow/compare/v0.22.0...v0.23.0)

##### What's Changed

- Update go.mod files post v0.22, restore CI by
[@&#8203;jmacd](https://github.com/jmacd) in
[https://github.com/open-telemetry/otel-arrow/pull/180](https://github.com/open-telemetry/otel-arrow/pull/180)
- (boundedqueue): new semaphore implementation by
[@&#8203;moh-osman3](https://github.com/moh-osman3) in
[https://github.com/open-telemetry/otel-arrow/pull/174](https://github.com/open-telemetry/otel-arrow/pull/174)
- (concurrentbatchprocessor): propagate metadataKeys correctly when
using `multiShardBatcher` by
[@&#8203;moh-osman3](https://github.com/moh-osman3) in
[https://github.com/open-telemetry/otel-arrow/pull/184](https://github.com/open-telemetry/otel-arrow/pull/184)
- (otelarrowreceiver): asynchronous stream operations by
[@&#8203;moh-osman3](https://github.com/moh-osman3) in
[https://github.com/open-telemetry/otel-arrow/pull/181](https://github.com/open-telemetry/otel-arrow/pull/181)
- Remove the FIFO prioritizer; use least-loaded over all streams by
default by [@&#8203;jmacd](https://github.com/jmacd) in
[https://github.com/open-telemetry/otel-arrow/pull/186](https://github.com/open-telemetry/otel-arrow/pull/186)
- Lint fixes from open collector-contrib PRs. by
[@&#8203;jmacd](https://github.com/jmacd) in
[https://github.com/open-telemetry/otel-arrow/pull/188](https://github.com/open-telemetry/otel-arrow/pull/188)
- Release otel-arrow v0.23.0 by
[@&#8203;moh-osman3](https://github.com/moh-osman3) in
[https://github.com/open-telemetry/otel-arrow/pull/187](https://github.com/open-telemetry/otel-arrow/pull/187)

**Full Changelog**:
open-telemetry/otel-arrow@v0.22.0...v0.23.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <[email protected]>
Co-authored-by: Alex Boten <[email protected]>
codeboten referenced this pull request in open-telemetry/opentelemetry-collector-contrib May 16, 2024
…3.0 (#33050)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/open-telemetry/otel-arrow](https://github.com/open-telemetry/otel-arrow)
| `v0.22.0` -> `v0.23.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fopen-telemetry%2fotel-arrow/v0.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fopen-telemetry%2fotel-arrow/v0.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fopen-telemetry%2fotel-arrow/v0.22.0/v0.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fopen-telemetry%2fotel-arrow/v0.22.0/v0.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>open-telemetry/otel-arrow
(github.com/open-telemetry/otel-arrow)</summary>

###
[`v0.23.0`](https://github.com/open-telemetry/otel-arrow/releases/tag/v0.23.0)

[Compare
Source](https://github.com/open-telemetry/otel-arrow/compare/v0.22.0...v0.23.0)

##### What's Changed

- Update go.mod files post v0.22, restore CI by
[@&#8203;jmacd](https://github.com/jmacd) in
[https://github.com/open-telemetry/otel-arrow/pull/180](https://github.com/open-telemetry/otel-arrow/pull/180)
- (boundedqueue): new semaphore implementation by
[@&#8203;moh-osman3](https://github.com/moh-osman3) in
[https://github.com/open-telemetry/otel-arrow/pull/174](https://github.com/open-telemetry/otel-arrow/pull/174)
- (concurrentbatchprocessor): propagate metadataKeys correctly when
using `multiShardBatcher` by
[@&#8203;moh-osman3](https://github.com/moh-osman3) in
[https://github.com/open-telemetry/otel-arrow/pull/184](https://github.com/open-telemetry/otel-arrow/pull/184)
- (otelarrowreceiver): asynchronous stream operations by
[@&#8203;moh-osman3](https://github.com/moh-osman3) in
[https://github.com/open-telemetry/otel-arrow/pull/181](https://github.com/open-telemetry/otel-arrow/pull/181)
- Remove the FIFO prioritizer; use least-loaded over all streams by
default by [@&#8203;jmacd](https://github.com/jmacd) in
[https://github.com/open-telemetry/otel-arrow/pull/186](https://github.com/open-telemetry/otel-arrow/pull/186)
- Lint fixes from open collector-contrib PRs. by
[@&#8203;jmacd](https://github.com/jmacd) in
[https://github.com/open-telemetry/otel-arrow/pull/188](https://github.com/open-telemetry/otel-arrow/pull/188)
- Release otel-arrow v0.23.0 by
[@&#8203;moh-osman3](https://github.com/moh-osman3) in
[https://github.com/open-telemetry/otel-arrow/pull/187](https://github.com/open-telemetry/otel-arrow/pull/187)

**Full Changelog**:
open-telemetry/otel-arrow@v0.22.0...v0.23.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <[email protected]>
Co-authored-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants