Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support use of local link checker #660

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Aug 12, 2021

When testing locally, if you have htmltest in your path, that command will be used. Otherwise, a copy will be fetched.

Closes #546

@chalin chalin added the CI/infra CI & infrastructure label Aug 12, 2021
@chalin chalin requested a review from shelbyspees August 12, 2021 13:09
@chalin chalin requested a review from a team August 12, 2021 13:09
@chalin
Copy link
Contributor Author

chalin commented Aug 12, 2021

From the build log, we can see that htmltest is still being fetched, and links are being checked:

9:10:16 AM: hugo ...
9:10:16 AM: 	--minify
9:10:19 AM: Building sites …
9:10:19 AM: Total in 3269 ms
9:10:19 AM: curl https://htmltest.wjdp.uk | bash -s -- -b tmp/bin
9:10:19 AM:  ...
9:10:20 AM: wjdp/htmltest info checking GitHub for latest tag
9:10:20 AM: wjdp/htmltest info found version: 0.14.0 for v0.14.0/linux/amd64
9:10:22 AM: wjdp/htmltest info installed tmp/bin/htmltest
9:10:22 AM: tmp/bin/htmltest
9:10:22 AM: htmltest started at 01:10:22 on public
9:10:22 AM: ========================================================================
9:10:22 AM: ✔✔✔ passed in 243.385591ms
9:10:22 AM: tested 397 documents
9:10:22 AM: ​
9:10:22 AM: (build.command completed in 23.2s)

@mtwo mtwo merged commit 53f000c into main Aug 13, 2021
@mtwo mtwo deleted the chalin-fix-link-checking-2021-08-12 branch August 13, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make ci-link-check fails on MacOS
2 participants