Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating services md file to remove service suffix from source link url #5945

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

vinodrkumars
Copy link
Contributor

@vinodrkumars vinodrkumars commented Jan 15, 2025

updating services md file to remove service suffix from source link url

@vinodrkumars vinodrkumars requested a review from a team as a code owner January 15, 2025 20:51
@opentelemetrybot opentelemetrybot requested a review from a team January 15, 2025 20:52
@chalin
Copy link
Contributor

chalin commented Jan 16, 2025

/fix:refcache

@opentelemetrybot
Copy link
Collaborator

You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12815025212

@opentelemetrybot
Copy link
Collaborator

fix:refcache was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and all checks are passing.

@chalin chalin requested a review from puckpuck January 16, 2025 18:33
@chalin
Copy link
Contributor

chalin commented Jan 16, 2025

@puckpuck or any @open-telemetry/demo-approvers - ready for a final approval.

@chalin
Copy link
Contributor

chalin commented Jan 16, 2025

Thanks for the review @reyang.

@chalin
Copy link
Contributor

chalin commented Jan 16, 2025

We have all approvals (review requests were reset just because I rebased). Merging!

@chalin chalin merged commit 98a5289 into open-telemetry:main Jan 16, 2025
17 checks passed
meswapnilk pushed a commit to meswapnilk/opentelemetry.io that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants