-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Flagd-ui to demo docs #5332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I commented with a few change requests
@svrnm Thank you for the review, I've applied the suggested changes in the last commit |
thanks! @open-telemetry/demo-approvers please take a look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we just need to get the Helm chart PR merged before merging this one to avoid user's confusion.
Also, could you add the flagd-ui
to the architecture page?
https://github.com/open-telemetry/opentelemetry.io/blob/main/content/en/docs/demo/architecture.md
I have it updated here if you would like: mermaid.live
…lemetry.io into demo-flagd-ui-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion, renaming the title and moving the initial sentence.
LGTM, just waiting on open-telemetry/opentelemetry-helm-charts#1367 |
just let us know when that PR is merged so we can revisit this one! thanks! |
@svrnm this one should be good to go. |
Changes
Changes required for the documentation concerning the flagd-ui feature.
As we have a ready PR for the first version of the flagd-ui, we would like to start thinking about how this new feature can be included in the documentation. Below you can find what I've implemented in this PR as my suggestions:
As it is not directly a microservice of the astronomy shop app, but it is an instrumented service nonetheless, there a few where it might make sense to include it (the flagd service itself is currently not included in these):
Additionally it might make sense to create a separate docs page for this feature at some point.
Thank you in advance for reviewing! 🚀
Let me know if I missed anything :)