Fixing the Python benchmark graph Layout #4174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cvr421 <[email protected]>
|
Hello @cartermp @chalin please review this PR and let me know your thoughts . Thanks |
svrnm
previously requested changes
Mar 19, 2024
Comment on lines
10
to
15
| @media (min-width: 100px) { | ||
| h3{ | ||
| font-size: 0.9rem; | ||
| font-weight: bold; | ||
| } | ||
| } |
There was a problem hiding this comment.
Can you make the css specific to the benchmark pages so it is not affecting any other page?
If I understand Problem and solution correctly the titles are too long non-breaking words? Is there a way to force breaking them or change the word breaking behavior?
There was a problem hiding this comment.
@svrnm i Have made the changes requested by you please review .
ocelotl
approved these changes
Mar 20, 2024
cartermp
approved these changes
Mar 25, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layout of the python benchmark graph is not properly align. It is overflowing to the other component.
Fixing issue #4170
Issue
Expected Behavior
