Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[demo/cartservice] Add support for logs #3213

Merged
merged 5 commits into from
Aug 31, 2023
Merged

[demo/cartservice] Add support for logs #3213

merged 5 commits into from
Aug 31, 2023

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Aug 31, 2023 •
edited
Loading

@Kielek Kielek mentioned this pull request Aug 31, 2023
Merged
2 tasks
@Kielek Kielek marked this pull request as ready for review August 31, 2023 07:33
@Kielek Kielek requested review from a team August 31, 2023 07:33
@Kielek @theletterf
PR feedback
8a2fe1b 
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
julianocosta89
julianocosta89 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating it @Kielek !

mviitane
mviitane approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Added only one minor comment.

content/en/docs/demo/services/cart.md Outdated Show resolved Hide resolved
@cartermp cartermp merged commit 4b66499 into open-telemetry:main Aug 31, 2023
@Kielek Kielek deleted the demo-cartservice-logging branch August 31, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm left review comments

@lachmatt lachmatt lachmatt approved these changes

@mviitane mviitane mviitane approved these changes

@julianocosta89 julianocosta89 julianocosta89 approved these changes

@theletterf theletterf theletterf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Kielek @svrnm @theletterf @julianocosta89 @mviitane @lachmatt @cartermp